Skip to content

perf: initialize project data if needed #5478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 27, 2021
Merged

perf: initialize project data if needed #5478

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0988626
perf: initialize project data if needed
janoshrubos Jan 19, 2021
50827e1
refactor: move validation to initializeProjectData
janoshrubos Jan 26, 2021
4b06d45
refactor: check initialization in the beginning of initializeProjectData
janoshrubos Jan 26, 2021
dea3a02
fix: negate type-o fix
janoshrubos Jan 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/definitions/project.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,7 @@ interface IProjectData extends ICreateProjectData {
infoPlistPath: string;
buildXcconfigPath: string;
podfilePath: string;
initialized?: boolean;
/**
* Defines if the project is a code sharing one.
* Value is true when project has nativescript.config and it has `shared: true` in it.
Expand Down
6 changes: 4 additions & 2 deletions lib/services/project-data-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,8 +119,10 @@ export class ProjectDataService implements IProjectDataService {
this.projectDataCache[projectDir] =
this.projectDataCache[projectDir] ||
this.$injector.resolve<IProjectData>(ProjectData);
this.projectDataCache[projectDir].initializeProjectData(projectDir);

if (!this.projectDataCache[projectDir].initialized) {
this.projectDataCache[projectDir].initializeProjectData(projectDir);
this.projectDataCache[projectDir].initialized = true;
}
return this.projectDataCache[projectDir];
}

Expand Down