fix: tns debug ios fails to show chrome url
#3648
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case when you do not have iOS Simulators running, the detection that checks if there are any simulators, takes 15 seconds. CLI executes this detection on various places. This leads to several issues, but the main one is the `tns debug ios` command when there's no running Simulators. In this case CLI often fails to display the URL for debugging as the timeout while waiting to get the port from iOS Device's logs passes while we are trying to find running simulators. Fix this by updating ios-sim-portable, where the detection does no longer wait 15 seconds - we just try twice for 500 ms to detect simulators and that's it.
TsvetanMilanov
approved these changes
May 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
tns debug iosfails when you have only iOS device attached.Also
tns devicescommand takes 18 seconds when there's no iOS Simulator running.What is the new behavior?
tns debug iosallows you to debug application on iOS Device.Also
tns devicescommand takes around 4 seconds when there's no iOS Simulator running.