Skip to content

fix(dynamic-links): ios parameters builder assigned to wrong variable #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 5, 2022
Merged

fix(dynamic-links): ios parameters builder assigned to wrong variable #162

merged 1 commit into from
Dec 5, 2022

Conversation

mukaschultze
Copy link
Contributor

Fix the variable assignment for DynamicLinkIOSParameters on Android, it's currently assigning the builder to the native parameters object. This incorrect assignment causes the following error when trying to generate short links:

JNI DETECTED ERROR IN APPLICATION: bad arguments passed to com.google.firebase.dynamiclinks.DynamicLink$Builder com.google.firebase.dynamiclinks.DynamicLink$Builder.setIosParameters(com.google.firebase.dynamiclinks.DynamicLink$IosParameters) (see above for details)

@cla-bot cla-bot bot added the cla: yes label Dec 5, 2022
@triniwiz triniwiz merged commit a4a5c45 into NativeScript:main Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mukaschultze @triniwiz