Added support for runtime options #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @return bool | ||
| */ | ||
| public static function hasOption($name) | ||
| { |
There was a problem hiding this comment.
It is safer to do array_key_exists($name, static::$options) in case someone sets a value as null for some reason. Also, when accessing static member variables and properties, prefer static:: to self::. The reason is that static supports late static binding whereas self does not.
|
Can you explain what the purpose of these run-time options is? One use case we need is to change behavior when we ask |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this commit is to allow support for access to set and get run-time options. Extensions of Monolog, such as Cascade, will need to set a run-time options from a config file and access it after parsing and losing access to the config file.