Remove _helperlib dep., implement attempt_nocopy_reshape in python for CUDA-specific changes #383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…empt_nocopy_reshape
|
Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
gmarkall
reviewed
Aug 7, 2025
There was a problem hiding this comment.
A quick note (not got really round to reviewing this yet) - numba_attempt_nocopy_reshape is already implemented in reshape_funcs.cu. There may be some merit to having the implementation in Python, but I think there is also the risk of it being less efficient in terms of register usage as I would guess it would use 64-bit ints in places where the .cu version uses int types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are only using the method
attempt_nocopy_reshapefrom numba's_helperlibC extension. This PR introduces a python implementation of attempt_nocopy_reshape for CUDA-specific customizations and to remove dependency on_helperlib.