[WIP] Initial attempt at CUDA 13 support / drop CUDA 11 #370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
/ok to test |
|
/ok to test |
|
Can't comment on the exact line but we should remove |
kkraus14
reviewed
Aug 4, 2025
kkraus14
reviewed
Aug 5, 2025
Co-authored-by: Keith Kraus <[email protected]>
|
/ok to test |
bdice
reviewed
Aug 9, 2025
| Conda users can install the CUDA Toolkit into a conda environment. | ||
|
|
||
| For CUDA 12:: | ||
| Conda users can install the CUDA Toolkit into a conda environment:: | ||
|
|
||
| $ conda install -c conda-forge numba-cuda "cuda-version>=12.0" |
There was a problem hiding this comment.
This will allow cuda-version 13.0 as written.
Suggested change
| $ conda install -c conda-forge numba-cuda "cuda-version>=12.0" | |
| $ conda install -c conda-forge numba-cuda "cuda-version=12" |
|
|
||
| $ pip install numba-cuda[cu12] | ||
| $ conda install -c conda-forge numba-cuda "cuda-version>=13.0" |
There was a problem hiding this comment.
Suggested change
| $ conda install -c conda-forge numba-cuda "cuda-version>=13.0" | |
| $ conda install -c conda-forge numba-cuda "cuda-version=13" |
| numba_include = f"{os.path.join(numba_cuda_path, 'include', '11')}" | ||
| else: | ||
| numba_include = f"{os.path.join(numba_cuda_path, 'include', '12')}" | ||
| numba_include = f"{os.path.join(numba_cuda_path, 'include', '12')}" |
There was a problem hiding this comment.
Might need additional logic for CUDA 13.
| cu13 = [ | ||
| "cuda-bindings==13.0.*", | ||
| "cuda-core==0.3.*", | ||
| "cuda-python==13.0.*", # supports all CTK 12.x |
There was a problem hiding this comment.
Suggested change
| "cuda-python==13.0.*", # supports all CTK 12.x | |
| "cuda-python==13.0.*", # supports all CTK 13.x |
bdice
reviewed
Aug 9, 2025
Comment on lines
+37
to
+40
| "nvidia-cuda-nvcc=13.*", # for libNVVM | ||
| "nvidia-cuda-runtime=13.*", | ||
| "nvidia-cuda-nvrtc=13.*", | ||
| "nvidia-nvjitlink=13.*" |
There was a problem hiding this comment.
I think CI is failing because of incompatible dependency specifiers.
configuration error: `project.optional-dependencies.cu13[3]` must be pep508
Suggested change
| "nvidia-cuda-nvcc=13.*", # for libNVVM | |
| "nvidia-cuda-runtime=13.*", | |
| "nvidia-cuda-nvrtc=13.*", | |
| "nvidia-nvjitlink=13.*" | |
| "nvidia-cuda-nvcc==13.*", # for libNVVM | |
| "nvidia-cuda-runtime==13.*", | |
| "nvidia-cuda-nvrtc==13.*", | |
| "nvidia-nvjitlink==13.*" |
| test-cu12 = [ | ||
| "numba-cuda[test]", | ||
| "nvidia-curand-cu12", | ||
| ] | ||
| test-cu13 = [ | ||
| "numba-cuda[test]", | ||
| "nvidia-curand=10.4.*", |
There was a problem hiding this comment.
Suggested change
| "nvidia-curand=10.4.*", | |
| "nvidia-curand==10.4.*", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial draft of support / test on CI.