Skip to content

Make it clear cuda-pathfinder is installed as part of cuda-python #827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 12, 2025

Conversation

leofang
Copy link
Member

@leofang leofang commented Aug 11, 2025

Description

closes #825.

This is achieved by

  1. mentioning cuda.pathfinder in cuda-python's release notes
  2. including cuda-pathfinder as a dependency of cuda-python:
    • the pinning should be as loose as possible and controlled more tightly by cuda-bindings and future included components

Note: When pathfinder has its own docs (#760), we should supply hyperlinks to wherever it's mentioned

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@leofang leofang added this to the cuda-python parking lot milestone Aug 11, 2025
@leofang leofang requested review from rwgk and kkraus14 August 11, 2025 13:51
@leofang leofang self-assigned this Aug 11, 2025
@leofang leofang added documentation Improvements or additions to documentation P0 High priority - Must do! packaging Anything related to wheels or Conda packages cuda.pathfinder Everything related to the cuda.pathfinder module labels Aug 11, 2025
@github-project-automation github-project-automation bot moved this to Todo in CCCL Aug 11, 2025
Copy link
Contributor

copy-pr-bot bot commented Aug 11, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@leofang
Copy link
Member Author

leofang commented Aug 11, 2025

/ok to test 9aa38db

This comment has been minimized.

kkraus14
kkraus14 previously approved these changes Aug 11, 2025
@github-project-automation github-project-automation bot moved this from Todo to In Review in CCCL Aug 11, 2025
rwgk
rwgk previously approved these changes Aug 11, 2025
Copy link
Collaborator

@rwgk rwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @leofang for taking care of this!

@leofang leofang dismissed stale reviews from rwgk and kkraus14 via 6abdea8 August 12, 2025 16:44
@leofang
Copy link
Member Author

leofang commented Aug 12, 2025

/ok to test 6abdea8

@leofang leofang enabled auto-merge (squash) August 12, 2025 16:47
@leofang leofang merged commit b87c787 into NVIDIA:main Aug 12, 2025
91 of 94 checks passed
@github-project-automation github-project-automation bot moved this from In Review to Done in CCCL Aug 12, 2025
@leofang leofang deleted the pathfinder_inclusion branch August 12, 2025 17:55
Copy link

Doc Preview CI
Preview removed because the pull request was closed or merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cuda.pathfinder Everything related to the cuda.pathfinder module documentation Improvements or additions to documentation P0 High priority - Must do! packaging Anything related to wheels or Conda packages
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[DOC]: CUDA Python 12.9.1 Release notes are incomplete
3 participants