Skip to content

[Backport] Bump pathfinder to v1.1.0 #806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 6, 2025

Conversation

leofang
Copy link
Member

@leofang leofang commented Aug 6, 2025

Description

Manual backport of #805

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

Copy link
Contributor

copy-pr-bot bot commented Aug 6, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@leofang leofang requested review from rwgk and kkraus14 August 6, 2025 15:52
@leofang leofang self-assigned this Aug 6, 2025
@leofang leofang added P0 High priority - Must do! packaging Anything related to wheels or Conda packages cuda.bindings Everything related to the cuda.bindings module cuda.pathfinder Everything related to the cuda.pathfinder module labels Aug 6, 2025
@leofang leofang added this to the cuda-python 13.0.0 & 12.9.1 milestone Aug 6, 2025
@leofang leofang changed the title [Backport] Bump pathfinder to v1.0.1 [Backport] Bump pathfinder to v1.1.0 Aug 6, 2025
@leofang
Copy link
Member Author

leofang commented Aug 6, 2025

/ok to test aa85831

@@ -1,4 +1,4 @@
# SPDX-FileCopyrightText: Copyright (c) 2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
# SPDX-License-Identifier: Apache-2.0

__version__ = "1.0.0"
__version__ = "1.1.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we committed to keeping pathfinder in sync between main and 12.9.x? It's a bit funky that we'll have two different sources of cuda-pathfinder 1.1.0 that aren't the same.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great question. I think you've discovered a flaw in the current CI design... we weren't prepared to always fetch the pathfinder wheel from the main branch. So right now with the backport branch we do have two different sources...

As a bandaid, I can manually backport all changes in the pathfinder from the main branch. Later we can improve the CI design to fetch pathfinder from the main branch in the 12.9.x CI (just like how we fetch 12.9.x wheels from the backport branch in the main CI, but in the reversed direction). WDYT?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a bandaid, I can manually backport all changes in the pathfinder from the main branch.

This is done in commit 8629941

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds good to me.

@leofang leofang marked this pull request as draft August 6, 2025 16:14
@github-project-automation github-project-automation bot moved this from Todo to In Review in CCCL Aug 6, 2025
@leofang
Copy link
Member Author

leofang commented Aug 6, 2025

/ok to test 8629941

@leofang leofang marked this pull request as ready for review August 6, 2025 17:07
@leofang
Copy link
Member Author

leofang commented Aug 6, 2025

/ok to test ee7cb41

@leofang leofang enabled auto-merge (squash) August 6, 2025 17:08
@leofang leofang merged commit d1a166a into NVIDIA:12.9.x Aug 6, 2025
42 checks passed
@github-project-automation github-project-automation bot moved this from In Review to Done in CCCL Aug 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cuda.bindings Everything related to the cuda.bindings module cuda.pathfinder Everything related to the cuda.pathfinder module P0 High priority - Must do! packaging Anything related to wheels or Conda packages
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants