-
Notifications
You must be signed in to change notification settings - Fork 190
[Backport] Bump pathfinder to v1.1.0 #806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/ok to test aa85831 |
@@ -1,4 +1,4 @@ | |||
# SPDX-FileCopyrightText: Copyright (c) 2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | |||
# SPDX-License-Identifier: Apache-2.0 | |||
|
|||
__version__ = "1.0.0" | |||
__version__ = "1.1.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we committed to keeping pathfinder in sync between main
and 12.9.x
? It's a bit funky that we'll have two different sources of cuda-pathfinder 1.1.0 that aren't the same.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great question. I think you've discovered a flaw in the current CI design... we weren't prepared to always fetch the pathfinder wheel from the main branch. So right now with the backport branch we do have two different sources...
As a bandaid, I can manually backport all changes in the pathfinder from the main branch. Later we can improve the CI design to fetch pathfinder from the main branch in the 12.9.x
CI (just like how we fetch 12.9.x wheels from the backport branch in the main
CI, but in the reversed direction). WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a bandaid, I can manually backport all changes in the pathfinder from the main branch.
This is done in commit 8629941
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That sounds good to me.
/ok to test 8629941 |
/ok to test ee7cb41 |
Description
Manual backport of #805
Checklist