Skip to content

getting started example is complete #797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 6, 2025
Merged

getting started example is complete #797

merged 2 commits into from
Aug 6, 2025

Conversation

richardhboyd
Copy link
Contributor

Description

issue

I added the import for cupy and initialized the RNG so that the getting started example works if a user copies each snippet from the docs into an appropriate environment

Checklist

  • I am familiar with the Contributing Guidelines.
  • [N/A] New or existing tests cover these changes. (I didn't see any tests for the documentation other than just building it)
  • The documentation is up to date with these changes.

@github-project-automation github-project-automation bot moved this to Todo in CCCL Aug 5, 2025
@copy-pr-bot copy-pr-bot
Copy link
Contributor

copy-pr-bot bot commented Aug 5, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@richardhboyd
Copy link
Contributor Author

apologies for the force-pushes, I was trying to fix my GPG signature. it should be all good now.

@leofang leofang requested a review from shwina August 5, 2025 01:45
@leofang leofang added documentation Improvements or additions to documentation P1 Medium priority - Should do cuda.core Everything related to the cuda.core module labels Aug 5, 2025
@leofang leofang added this to the cuda.core beta 6 milestone Aug 5, 2025
shwina
shwina approved these changes Aug 5, 2025
View reviewed changes
Copy link
Contributor

@shwina shwina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks so much @richardhboyd !

@github-project-automation github-project-automation bot moved this from Todo to In Review in CCCL Aug 5, 2025
@shwina
Copy link
Contributor

shwina commented Aug 5, 2025

/ok to test cb0fa67

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 5, 2025

Doc Preview CI

🚀 View preview at
https://nvidia.github.io/cuda-python/pr-preview/pr-797/

https://nvidia.github.io/cuda-python/pr-preview/pr-797/cuda-core/

https://nvidia.github.io/cuda-python/pr-preview/pr-797/cuda-bindings/


Preview will be ready when the GitHub Pages deployment is complete.

@leofang
Copy link
Member

leofang commented Aug 5, 2025

FYI we are fixing the CI failures as part of #792.

@leofang
Copy link
Member

leofang commented Aug 6, 2025

/ok to test b8ab24c

@leofang leofang enabled auto-merge (squash) August 6, 2025 15:33
@leofang leofang linked an issue Aug 6, 2025 that may be closed by this pull request
[DOC]: 'Getting started' example does not run as documented #796
Closed
1 task
@leofang leofang merged commit efa91a6 into NVIDIA:main Aug 6, 2025
49 checks passed
@github-project-automation github-project-automation bot moved this from In Review to Done in CCCL Aug 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shwina shwina shwina approved these changes

Assignees
No one assigned
Labels
cuda.core Everything related to the cuda.core module documentation Improvements or additions to documentation P1 Medium priority - Should do
Projects
CCCL
Status: Done
Milestone
cuda.core beta 6
Development

Successfully merging this pull request may close these issues.

[DOC]: 'Getting started' example does not run as documented
3 participants
@richardhboyd @shwina @leofang