Skip to content

Construct instance of appropriate class in Event._init and Stream._init #752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 21, 2025
Merged

Construct instance of appropriate class in Event._init and Stream._init #752

merged 3 commits into from
Jul 21, 2025

Conversation

shwina
Copy link
Contributor

@shwina shwina commented Jul 10, 2025

Description

Closes #750

closes

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@github-project-automation github-project-automation bot moved this to Todo in CCCL Jul 10, 2025
@copy-pr-bot copy-pr-bot
Copy link
Contributor

copy-pr-bot bot commented Jul 10, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@shwina shwina mentioned this pull request Jul 10, 2025
Closed
1 task
@shwina
Copy link
Contributor Author

shwina commented Jul 11, 2025

/ok to test eb6890b

shwina
shwina commented Jul 11, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link

Doc Preview CI

🚀 View preview at
https://nvidia.github.io/cuda-python/pr-preview/pr-752/

https://nvidia.github.io/cuda-python/pr-preview/pr-752/cuda-core/

https://nvidia.github.io/cuda-python/pr-preview/pr-752/cuda-bindings/


Preview will be ready when the GitHub Pages deployment is complete.

carterbox
carterbox suggested changes Jul 11, 2025
View reviewed changes
Copy link
Contributor

@carterbox carterbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This same fix should also be applied to the Stream class.

@github-project-automation github-project-automation bot moved this from Todo to In Progress in CCCL Jul 11, 2025
kkraus14
kkraus14 reviewed Jul 11, 2025
View reviewed changes
@leofang leofang added enhancement Any code-related improvements P1 Medium priority - Should do cuda.core Everything related to the cuda.core module labels Jul 18, 2025
@leofang leofang added this to the cuda.core beta 6 milestone Jul 18, 2025
@shwina shwina changed the title Construct instance of appropriate class in Event._init Construct instance of appropriate class in Event._init and Stream._init Jul 21, 2025
@shwina
Copy link
Contributor Author

shwina commented Jul 21, 2025

Apologies for the delay. I added a test for Event subclassing and made similar changes for Stream.

@github-project-automation github-project-automation bot moved this from In Progress to In Review in CCCL Jul 21, 2025
@leofang
Copy link
Member

leofang commented Jul 21, 2025

/ok to test 3e264db

@leofang leofang merged commit 5d8b2d7 into NVIDIA:main Jul 21, 2025
53 checks passed
@github-project-automation github-project-automation bot moved this from In Review to Done in CCCL Jul 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwgk rwgk rwgk approved these changes

@kkraus14 kkraus14 kkraus14 approved these changes

@leofang leofang leofang approved these changes

+1 more reviewer

@carterbox carterbox carterbox approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@shwina shwina

Labels
cuda.core Everything related to the cuda.core module enhancement Any code-related improvements P1 Medium priority - Should do
Projects
CCCL
Archived in project
Milestone
cuda.core beta 6
Development

Successfully merging this pull request may close these issues.

[FEA]: private constructor prevents derived classes of cythonized Stream, Event
5 participants
@shwina @leofang @rwgk @kkraus14 @carterbox