-
Notifications
You must be signed in to change notification settings - Fork 189
Fix CI build-time parallelism + support the same env var in cuda.core
#743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cuda.core
cuda.core
pre-commit.ci autofix |
/ok to test 11796bc |
This comment has been minimized.
This comment has been minimized.
I eyeballed the build time change (against the main branch) and observed noticeable speedup! |
rwgk
reviewed
Jul 2, 2025
Let me admin-merge here. I need this in to study if we can relax Cython upper bound. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
CI/CD
CI/CD infrastructure
cuda.bindings
Everything related to the cuda.bindings module
cuda.core
Everything related to the cuda.core module
P0
High priority - Must do!
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
cuda.bindings
's long build time on linux-aarch64 #602 orcuda.bindings
build time on Linux becomes ~2x slower #642, but I noticed when reviewing Movepathfinder
to cuda-python top level #723 that the CI env var is set incorrectly, so it seems we're building with single threadsChecklist