Skip to content

Fix CI build-time parallelism + support the same env var in cuda.core #743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 2, 2025

Conversation

leofang
Copy link
Member

@leofang leofang commented Jul 2, 2025

Description

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@leofang leofang requested a review from cryos July 2, 2025 03:16
@leofang leofang self-assigned this Jul 2, 2025
@leofang leofang added P0 High priority - Must do! CI/CD CI/CD infrastructure cuda.bindings Everything related to the cuda.bindings module cuda.core Everything related to the cuda.core module labels Jul 2, 2025
@github-project-automation github-project-automation bot moved this to Todo in CCCL Jul 2, 2025
Copy link
Contributor

copy-pr-bot bot commented Jul 2, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@leofang leofang changed the title Fix CI build-time parallelim + support the same env var in cuda.core Fix CI build-time parallelism + support the same env var in cuda.core Jul 2, 2025
@leofang
Copy link
Member Author

leofang commented Jul 2, 2025

pre-commit.ci autofix

@leofang
Copy link
Member Author

leofang commented Jul 2, 2025

/ok to test 11796bc

@leofang leofang added the bug Something isn't working label Jul 2, 2025

This comment has been minimized.

@leofang
Copy link
Member Author

leofang commented Jul 2, 2025

I eyeballed the build time change (against the main branch) and observed noticeable speedup!

@leofang leofang added this to the cuda-python 12-next, 11-next milestone Jul 2, 2025
@leofang
Copy link
Member Author

leofang commented Jul 2, 2025

Let me admin-merge here. I need this in to study if we can relax Cython upper bound.

@leofang leofang merged commit 916097e into NVIDIA:main Jul 2, 2025
54 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in CCCL Jul 2, 2025
@leofang leofang deleted the fix_nproc branch July 2, 2025 22:56
Copy link

github-actions bot commented Jul 2, 2025

Doc Preview CI
Preview removed because the pull request was closed or merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CI/CD CI/CD infrastructure cuda.bindings Everything related to the cuda.bindings module cuda.core Everything related to the cuda.core module P0 High priority - Must do!
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants