Fix nvbugpro 5348750 #725
Merged
Fix nvbugpro 5348750 #725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
LGTM, is it still a draft? |
|
/ok to test |
|
@leofang I opened it as a draft. Will transition to 'ready-for-review' once CI gree-lights the change. |
leofang
added
bug
This comment has been minimized.
This comment has been minimized.
oleksandr-pavlyk
force-pushed
the
fix-nvbugpro-5348750
branch
from
cf74c40 to
2ddc6f2
Compare
|
/ok to test |
For drivers in version range [12000, 12040), do not add "paraminfo" to the _loader dictionary. At runtime, raise NotImplementedError if "paraminfo" is not in the dictionary. Only modify _loader["new"] for python version >=12
…lParamInfo Except for one test where we check that NotImplementedError is raised.
oleksandr-pavlyk
force-pushed
the
fix-nvbugpro-5348750
branch
from
2ddc6f2 to
5a2f311
Compare
|
/ok to test |
Older driver, specifically 535.247.01, returns error code 400 for cluster-size related occupancy queries for devices with compute capability less than (9, 0) It works fine with newer drivers, provided the actual requested cluster size is zero.
|
/ok to test |
|
Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
2 tasks
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This build on top of #724 and changes
cuda.core.experimental._moduleto set_loader["paraminfo"]only when driver is>=12.4. If "paraminfo" is not found in_loaderat run-time, aNotImplementedErroris raised.closes
Checklist