Skip to content

Conversation

@mikemckiernan
Copy link
Collaborator

@mikemckiernan mikemckiernan commented Aug 26, 2025

Description

Reviewers requested a soup-to-nuts experience with Guardrails and the content safety multilingual NIM.

Review HTML: https://nvidia.github.io/NeMo-Guardrails/review/pr-1354/user-guides/advanced/nemotron-content-safety-multilingual-deployment.html

@miyoungc, if you could look this PR over first and let me know anything you'd like changed, that'd be great.

I tagged @tgasser-nv as a Guardrails SME, but I'm OK with whomever @cparisien can spare for a few minutes.

After eng SME review, I'll ask Zhenming if he can eventually find cycles to review for this unplanned work.

Related Issue(s)

Checklist

  • I've read the CONTRIBUTING guidelines.
  • I've updated the documentation if applicable.
  • I've added tests if applicable.
  • @mentions of the person or team responsible for reviewing proposed changes.

@mikemckiernan mikemckiernan self-assigned this Aug 26, 2025
@mikemckiernan mikemckiernan added the documentation Improvements or additions to documentation label Aug 26, 2025
@github-actions
Copy link
Contributor

Documentation preview

https://nvidia.github.io/NeMo-Guardrails/review/pr-1354

@codecov-commenter
Copy link

codecov-commenter commented Aug 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.62%. Comparing base (2732d3b) to head (5f12de1).
⚠️ Report is 9 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1354      +/-   ##
===========================================
+ Coverage    71.59%   71.62%   +0.03%     
===========================================
  Files          168      171       +3     
  Lines        16862    17020     +158     
===========================================
+ Hits         12072    12191     +119     
- Misses        4790     4829      +39     
Flag Coverage Δ
python 71.62% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@miyoungc miyoungc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for adding this doc!

Copy link
Member

@trebedea trebedea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link
Collaborator

@tgasser-nv tgasser-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, left a few comments to address before merging

@mikemckiernan mikemckiernan merged commit 1f35d7c into NVIDIA-NeMo:develop Sep 3, 2025
9 checks passed
tgasser-nv pushed a commit that referenced this pull request Sep 22, 2025
tgasser-nv pushed a commit that referenced this pull request Sep 22, 2025
Pouyanpi pushed a commit that referenced this pull request Oct 1, 2025
tgasser-nv pushed a commit that referenced this pull request Oct 14, 2025
tgasser-nv pushed a commit that referenced this pull request Oct 14, 2025
tgasser-nv pushed a commit that referenced this pull request Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants