-
Notifications
You must be signed in to change notification settings - Fork 1
Llane/home pg style edits #215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Lawrence Lane <[email protected]>
Signed-off-by: Lawrence Lane <[email protected]>
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Completed tech pubs review on index.md and provided a few copyedits.
Co-authored-by: jgerh <[email protected]> Signed-off-by: L.B. <[email protected]>
Co-authored-by: jgerh <[email protected]> Signed-off-by: L.B. <[email protected]>
Co-authored-by: jgerh <[email protected]> Signed-off-by: L.B. <[email protected]>
Co-authored-by: jgerh <[email protected]> Signed-off-by: L.B. <[email protected]>
Co-authored-by: jgerh <[email protected]> Signed-off-by: L.B. <[email protected]>
Co-authored-by: jgerh <[email protected]> Signed-off-by: L.B. <[email protected]>
Co-authored-by: jgerh <[email protected]> Signed-off-by: L.B. <[email protected]>
Co-authored-by: jgerh <[email protected]> Signed-off-by: L.B. <[email protected]>
Co-authored-by: jgerh <[email protected]> Signed-off-by: L.B. <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the effort! Left couple of comments
Signed-off-by: Lawrence Lane <[email protected]>
hey @agronskiy i think the minor change i made undid your approval (or i need a second approval?) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-approving after minor change
This is a very basic migration of the readme content + adding a minimal toctree to the home index page so that the sphinx site produces a sidebar. The sidebar will mature and break out in the future into sections such as About, Get Started, etc. We will also add more sections/cards to this page after all other basic edits have been checked in, so it won't be a direct copy of the README, instead it will become a proper docs site home page. --------- Signed-off-by: Lawrence Lane <[email protected]> Signed-off-by: L.B. <[email protected]> Co-authored-by: jgerh <[email protected]> Signed-off-by: Anna Warno <[email protected]>
This is a very basic migration of the readme content + adding a minimal toctree to the home index page so that the sphinx site produces a sidebar. The sidebar will mature and break out in the future into sections such as About, Get Started, etc.
We will also add more sections/cards to this page after all other basic edits have been checked in, so it won't be a direct copy of the README, instead it will become a proper docs site home page.