Skip to content

Conversation

@snakefoot
Copy link
Contributor

@snakefoot snakefoot commented Apr 5, 2020

Also optimized performance by reducing allocation for empty dictionary.

@snakefoot snakefoot added enhancement Improvement on existing feature performance labels Apr 5, 2020
@snakefoot snakefoot added this to the 4.7.1 milestone Apr 5, 2020
@snakefoot snakefoot force-pushed the ObjectReflectionReadOnlyDictFaster branch from 68ea14c to df8177d Compare April 5, 2020 18:15
@snakefoot snakefoot force-pushed the ObjectReflectionReadOnlyDictFaster branch from df8177d to 9b672d0 Compare April 5, 2020 18:47
@snakefoot snakefoot force-pushed the ObjectReflectionReadOnlyDictFaster branch 4 times, most recently from 3161c88 to 53ad861 Compare April 6, 2020 19:56
Copy link
Member

@304NotModified 304NotModified left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@snakefoot snakefoot force-pushed the ObjectReflectionReadOnlyDictFaster branch 2 times, most recently from 6241ce3 to cdff8d7 Compare April 7, 2020 09:49
@snakefoot snakefoot force-pushed the ObjectReflectionReadOnlyDictFaster branch from cdff8d7 to bb053fc Compare April 7, 2020 10:19
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 7, 2020

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 3 Code Smells

78.6% 78.6% Coverage
0.0% 0.0% Duplication

Copy link
Member

@304NotModified 304NotModified left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please no force pushes after revriew

@snakefoot
Copy link
Contributor Author

Sorry. I was just playing with code-coverage.

@304NotModified
Copy link
Member

cool!

One thing, the PR name. I don't think end users could understand this. I don't know how to rename this one.

@304NotModified
Copy link
Member

One thing, the PR name. I don't think end users could understand this. I don't know how to rename this one.

Any good ideas?

@snakefoot
Copy link
Contributor Author

Any good ideas?

Nope. It does as the title say. Allow expando objects to work without implementing IDictionary or IDictionary<TKey,TValue>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Improvement on existing feature size/L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants