Fix some bugs in testing #1423
Merged
Fix some bugs in testing #1423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-project-automation
bot
moved this to Finding Reviewers
in FATES Pull Request Planning and Status
Contributor
Author
|
@ekluzek and @samsrabin this PR shows the necessity of having the unit (and functional?) tests be able to be run with a system test (on derecho). |
glemieux
reviewed
Jun 12, 2025
Contributor
glemieux
left a comment
glemieux
left a comment
There was a problem hiding this comment.
One clarifying question
Contributor
I've made some changes to enable this; submitted as PR adrifoster#4. CTSM PR with the test: ESCOMP/CTSM#3251 |
glemieux
approved these changes
Jun 18, 2025
Contributor
glemieux
left a comment
glemieux
left a comment
There was a problem hiding this comment.
Per conversation with @adrifoster, merging this in after fixing some conflicts that came up with merging in main.
github-project-automation
bot
moved this from Finding Reviewers
to Ready to Integrate
in FATES Pull Request Planning and Status
Contributor
|
Great! Now I'll rebase my PR from Adrianna's fork to here. |
Contributor
|
PR now here at #1426. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some bugs in our testing code that arose from recent PRs.
Also fixes some CMakeLists.txt issues due to recent CIME changes.
Description:
Minor bug fixes
Collaborators:
@samsrabin
@billsacks
Expectation of Answer Changes:
None - only changes testing code