Skip to content

Conversation

@MusicalNinjaDad
Copy link
Owner

  • Breaking: Changed top level module name to fizzbuzz. Use from fizzbuzz.fizzbuzzo3 import fizzbuzz
    for rust implementation or from fizzbuzz.fizzbuzzpy import fizzbuzz for python implementation (slower).
  • Added typing and docstring hints available in IDE

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @MusicalNinjaDad - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 2 issues found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@MusicalNinjaDad MusicalNinjaDad merged commit c132883 into main May 13, 2024
@MusicalNinjaDad MusicalNinjaDad deleted the docstring_hints branch May 13, 2024 05:34
MusicalNinjaDad added a commit that referenced this pull request May 13, 2024
MusicalNinjaDad added a commit that referenced this pull request May 13, 2024
This reverts commits
c132883
869663a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants