MudCarousel: Fix UI update of bullets on item add #11873
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request addresses a UI bug where carousel bullets were not updating upon adding a new item. The change correctly moves StateHasChanged() to be called unconditionally, ensuring the component re-renders. However, the submission lacks a unit test to cover this bug fix. The project's style guide mandates that all logic changes must be accompanied by tests. Adding a test would prevent future regressions of this issue.
versile2
approved these changes
Sep 18, 2025
Contributor
versile2
left a comment
versile2
left a comment
There was a problem hiding this comment.
Code is simple and sound.
Verified the unit test fails before the code change and passes after.
Visually verified Viewer WASM and Docs BSS to ensure no oddities or artifacts.
Member
|
Thank you! |
danielchalmers
added
bug
This was referenced Oct 1, 2025
Closed
This was referenced Oct 6, 2025
This was referenced Oct 13, 2025
Closed
This was referenced Oct 21, 2025
Closed
This was referenced Nov 1, 2025
Open
This was referenced Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trigger StateHasChanged on MudCarousel.AddItem to render the bullets correctly
Resolves #11798
Checklist