feat(AppDataSearch): add customizable placeholder prop #23
+288
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Summary
This PR introduces a `placeholder` prop to the `AppDataSearch` component, allowing consumers to define custom placeholder text instead of using the hardcoded "Search".
### Changes
- Added `placeholder` prop with default value `"Search"`
- Updated template to use `:placeholder="placeholder"` instead of `__('Search')`
- Maintains backward compatibility (defaults to `"Search"` if no prop is passed)
### Usage Example
```vue
<AppDataSearch
:url="route('student.index')"
fields-to-search="name"
placeholder="Search by student name"
></AppDataSearch>
- Implemented a reusable multi-select combobox component (`AppMultiCombobox.vue`) - Supports search, tag-style selected items, and keyboard navigation - Emits `update:modelValue` with array of selected options - Styled consistently with existing `AppCombobox` component - Enables selecting multiple recipients in message compose form
…n State Fullscreen Toggle Added a fullscreen button with smooth rotate + scale animation. Fullscreen state icon (maximize / minimize) persists in localStorage. Automatically updates icon when exiting fullscreen via Esc. Notes: Fullscreen cannot be automatically restored on page reload due to browser security restrictions; only the icon state persists. Logout and theme toggling functionality remain unaffected.
- Updated logout() to redirect to GET route 'adminAuth.loginForm' instead of POST login route. - Ensures a fresh CSRF token is generated and avoids 419 Page Expired errors on first login after logout. - Session is invalidated and CSRF token regenerated for security.
Fix Logout to Redirect to Login Form and Prevent 419 Error
daniel-cintra
requested changes
Sep 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a
placeholderprop to theAppDataSearchcomponent, allowing consumers to define custom placeholder text instead of using the hardcoded "Search".Changes
placeholderprop with default value"Search":placeholder="placeholder"instead of__('Search')"Search"if no prop is passed)Usage Example