Skip to content

Conversation

@james-nesbitt
Copy link
Collaborator

@james-nesbitt james-nesbitt commented May 29, 2025

perform some version to channel validation as recent versions of MCR need to have config version and config channel coordinated in order to pin versions properly.

  • MCRConfig now has some config validation, in particular MCR25 and later need to have properly coupled channel and version; tests created for valid and invalid version/channel combinations
  • ValidateFacts now runs MCR Config validation; this required adding MCR config so some of the testing Spec Configs, or validation will fail the test.
  • Also added some err handling changes to pass linting

- go modules update
- terraform modules update

Signed-off-by: James Nesbitt <[email protected]>
@james-nesbitt james-nesbitt marked this pull request as draft May 29, 2025 11:38
@james-nesbitt james-nesbitt force-pushed the PRODENG-3025-mcr-version-channel-check branch 2 times, most recently from 3d53e00 to 77a0124 Compare May 30, 2025 11:34
- mcr config now has a validate function that checks and mcr config and validates channel and version.
- mke project validate facts now checks runs MCR validation check and fails if not-valid

Signed-off-by: James Nesbitt <[email protected]>
@james-nesbitt james-nesbitt force-pushed the PRODENG-3025-mcr-version-channel-check branch from 77a0124 to 0cf851a Compare May 30, 2025 11:46
@james-nesbitt james-nesbitt marked this pull request as ready for review May 30, 2025 12:47
@james-nesbitt james-nesbitt requested review from kke, nekwar and pgedara May 30, 2025 12:48
Copy link
Contributor

@pgedara pgedara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@james-nesbitt james-nesbitt merged commit feb9fcf into main Jun 3, 2025
7 checks passed
@james-nesbitt james-nesbitt deleted the PRODENG-3025-mcr-version-channel-check branch June 3, 2025 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants