- 
                Notifications
    You must be signed in to change notification settings 
- Fork 583
Replace run-localnet.sh with mina-local-network.sh #18031
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Draft
      
      
            glyh
  wants to merge
  45
  commits into
  lyh/more-improve-on-hf-test-go
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
lyh/retire-run-localnet-sh
  
      
      
   
  
    
  
  
  
 
  
      
    base: lyh/more-improve-on-hf-test-go
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          
                
     Draft
            
            
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    …-network cli args
22dc15c    to
    5d8ea71      
    Compare
  
    72f1b6f    to
    c0231b4      
    Compare
  
    | !ci-nightly-me | 
c0231b4    to
    562a227      
    Compare
  
    | !ci-nightly-me | 
… support delay_sec
another config file
…ts existed network with replaced new config and genesis ledgers
| !ci-nightly-me | 
    
      
        1 similar comment
      
    
  
    | !ci-nightly-me | 
              
                    glyh
  
              
              commented
              
                  
                    Oct 29, 2025 
                  
              
              
            
            
| t.Logger.Info("Stopping nodes...") | ||
| // TODO: ensure integrity of ports in hf-test-go and mina-local-network | ||
|  | ||
| const SEED_START_PORT = 3000 | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These matches up with what we have in mina-local-network.sh
…s producing proofs
… they already exited
90e7a56    to
    2af4917      
    Compare
  
    | !ci-nightly-me | 
| !ci-nightly-me | 
    
      
        1 similar comment
      
    
  
    | !ci-nightly-me | 
1428a91    to
    fb7a3d9      
    Compare
  
    | !ci-nightly-me | 
fb7a3d9    to
    a0a5151      
    Compare
  
    | !ci-nightly-me | 
a0a5151    to
    06746c7      
    Compare
  
    | !ci-nightly-me | 
06746c7    to
    c121292      
    Compare
  
    | !ci-nightly-me | 
…t silently passing the test
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Note
This PR obserb most features from run-localnet.sh into mina-local-network.
There's still something missing so run-localnet.sh couldn't be just deleted now.
TODOs
Difference before/after the port
run-localnet.shmina-local-network.shscripts/prepare-test-ledger.shscripts/mina-local-network/generate-mina-local-network-ledger.py