Skip to content

Implement safe mode for Rosetta #17997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: compatible
Choose a base branch
from
Open

Implement safe mode for Rosetta #17997

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions src/app/rosetta/lib/rosetta.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ let router ~signature_kind ~graphql_uri ~minimum_user_command_fee
( (Caqti_async.connection, [> Caqti_error.connect ]) Mina_caqti.Pool.t
, [ `App of Errors.t ] )
Deferred.Result.t
lazy_t ) ~logger route body =
lazy_t ) ~logger ~safe_mode route body =
let open Deferred.Result.Let_syntax in
let get_graphql_uri_or_error () =
match graphql_uri with
Expand Down Expand Up @@ -47,14 +47,14 @@ let router ~signature_kind ~graphql_uri ~minimum_user_command_fee
let%bind graphql_uri = get_graphql_uri_or_error () in
Account.router tl body ~graphql_uri ~logger ~with_db
~minimum_user_command_fee
| "mempool" :: tl ->
| "mempool" :: tl when not safe_mode ->
let%bind graphql_uri = get_graphql_uri_or_error () in
Mempool.router tl body ~graphql_uri ~logger ~minimum_user_command_fee
| "block" :: tl ->
let%bind graphql_uri = get_graphql_uri_or_error () in
Block.router tl body ~graphql_uri ~logger ~with_db:with_db'
~minimum_user_command_fee
| "construction" :: tl ->
| "construction" :: tl when not safe_mode ->
Construction.router tl body ~signature_kind ~get_graphql_uri_or_error
~logger ~with_db:with_db' ~minimum_user_command_fee
~account_creation_fee
Expand Down Expand Up @@ -108,18 +108,18 @@ let pg_log_data ~logger ~pool : unit Deferred.t =
Deferred.unit

let server_handler ~signature_kind ~pool ~graphql_uri ~logger
~minimum_user_command_fee ~account_creation_fee ~body _sock req =
~minimum_user_command_fee ~account_creation_fee ~body ~safe_mode _sock req =
let uri = Cohttp_async.Request.uri req in
let%bind body = Cohttp_async.Body.to_string body in
let route = List.tl_exn (String.split ~on:'/' (Uri.path uri)) in
let%bind result =
match Yojson.Safe.from_string body with
| body ->
router route body ~signature_kind ~pool ~graphql_uri ~logger
~minimum_user_command_fee ~account_creation_fee
~minimum_user_command_fee ~account_creation_fee ~safe_mode
| exception Yojson.Json_error "Blank input data" ->
router route `Null ~signature_kind ~pool ~graphql_uri ~logger
~minimum_user_command_fee ~account_creation_fee
~minimum_user_command_fee ~account_creation_fee ~safe_mode
| exception Yojson.Json_error err ->
Errors.create ~context:"JSON in request malformed"
(`Json_parse (Some err))
Expand Down Expand Up @@ -173,6 +173,12 @@ let command ?signature_kind ~minimum_user_command_fee ~account_creation_fee () =
and port =
flag "--port" ~aliases:[ "port" ] ~doc:"Port to expose Rosetta server"
(required int)
and safe_mode =
flag "--safe-mode" ~aliases:[ "safe-mode" ]
~doc:
"Enable safe mode, meaning only data safe to expose to public would be \
routed. And any mutation should be banned."
no_arg
and signature_kind =
Option.value_map signature_kind ~default:Cli_lib.Flag.signature_kind
~f:Command.Param.return
Expand Down Expand Up @@ -235,7 +241,7 @@ let command ?signature_kind ~minimum_user_command_fee ~account_creation_fee () =
ignore (exit 1) ) )
(Async.Tcp.Where_to_listen.bind_to All_addresses (On_port port))
(server_handler ~signature_kind ~pool ~graphql_uri ~logger
~minimum_user_command_fee ~account_creation_fee )
~minimum_user_command_fee ~account_creation_fee ~safe_mode )
in
[%log info]
~metadata:[ ("port", `Int port) ]
Expand Down