[CI] Fix packages name conflict between mina-devnet and mina-devnet-lightnet #17959
Conversation
|
!ci-build-me |
|
!ci-nightly-me |
dkijania
force-pushed
the
dkijania/fix_amd64_arm64_dups
branch
from
a3db9ac to
d0aad45
Compare
|
Scheduled nightly : https://buildkite.com/o-1-labs-2/mina-mainline-branches-nightlies/builds/710 |
|
!ci-build-me |
dkijania
force-pushed
the
dkijania/fix_amd64_arm64_dups
branch
from
d0aad45 to
8e9d3e4
Compare
dkijania
changed the title
|
!ci-build-me |
| ## END MAINNET PACKAGE ## | ||
|
|
||
| ## DEVNET PACKAGE ## | ||
| build_daemon_devnet_deb() { |
There was a problem hiding this comment.
Rename this function, or document a bit to better reflect what we're actually doing, or at least point out what build profile we're using this for?
This is so when 3 months later someone picking up this understand why it's used for lightnet.
Or should we just create another function named build_daemon_lightnet_deb?
BTW, despite used for lightnet, is it also used for berkeley?
There was a problem hiding this comment.
unfortunately it's not so easy. As this method name is used in ./script/debian/build.sh which react on request for building some debian with name and execute function ("build_${i}_deb"). So renaming this method will break other stuff. Lightnet is teated as variation for mina berkeley or devnet.
I don't argue that we shouldn't rewrite it but maybe not in this PR. i can add docs
|
@glyh I added docs |
|
!ci-build-me |
Recently we are experiencing issues in CI: https://buildkite.com/o-1-labs-2/mina-mainline-branches-nightlies/builds/694
This is caues by conflict in package name between lightnet and standard mina-devnet.
mina-devnet-lightnet package name was the same like in mina-devnet (despite fact that that they were placed in different debians).