Skip to content

[AndyAyersMS] [X64] JIT: fix recursive inline check #125

@MihuBot

Description

@MihuBot

Build completed in 1 hour 12 minutes.
dotnet/runtime#88749

CoreLib diffs

Found 1 files with textual diffs.

Summary of Code Size diffs:
(Lower is better)

Total bytes of base: 6532877
Total bytes of diff: 6532877
Total bytes of delta: 0 (0.00 % of base)


0 total files with Code Size differences (0 improved, 0 regressed), 1 unchanged.

0 total methods with Code Size differences (0 improved, 0 regressed), 52530 unchanged.

--------------------------------------------------------------------------------

Frameworks diffs

Diffs
Found 263 files with textual diffs.

Summary of Code Size diffs:
(Lower is better)

Total bytes of base: 37931905
Total bytes of diff: 37933801
Total bytes of delta: 1896 (0.00 % of base)
Total relative delta: 9.77
    diff is a regression.
    relative diff is a regression.


Top file regressions (bytes):
         829 : System.Collections.Immutable.dasm (0.04 % of base)
         600 : System.Data.Common.dasm (0.04 % of base)
         596 : System.ComponentModel.Composition.dasm (0.15 % of base)
          72 : System.IO.Packaging.dasm (0.07 % of base)
           7 : System.Private.DataContractSerialization.dasm (0.00 % of base)

Top file improvements (bytes):
        -194 : Microsoft.NET.WebAssembly.Webcil.dasm (-0.80 % of base)
         -14 : System.Private.Xml.dasm (-0.00 % of base)

7 total files with Code Size differences (2 improved, 5 regressed), 248 unchanged.

Top method regressions (bytes):
         600 (154.24 % of base) : System.Data.Common.dasm - System.Data.RBTree`1[System.Numerics.Vector`1[float]]:IndexOf(int,System.Numerics.Vector`1[float]):int:this (FullOpts)
         298 (85.39 % of base) : System.ComponentModel.Composition.dasm - System.ComponentModel.Composition.Hosting.ImportEngine+EngineContext:GetAddedPartManagers():System.Collections.Generic.IEnumerable`1[System.ComponentModel.Composition.Hosting.ImportEngine+PartManager]:this (FullOpts)
         298 (85.39 % of base) : System.ComponentModel.Composition.dasm - System.ComponentModel.Composition.Hosting.ImportEngine+EngineContext:GetRemovedPartManagers():System.Collections.Generic.IEnumerable`1[System.ComponentModel.Composition.Hosting.ImportEngine+PartManager]:this (FullOpts)
         213 (75.80 % of base) : System.Collections.Immutable.dasm - System.Collections.Immutable.ImmutableList`1+Node[System.Numerics.Vector`1[float]]:Add(System.Numerics.Vector`1[float]):System.Collections.Immutable.ImmutableList`1+Node[System.Numerics.Vector`1[float]]:this (FullOpts)
          99 (55.31 % of base) : System.Collections.Immutable.dasm - System.Collections.Immutable.ImmutableList`1+Node[System.Numerics.Vector`1[float]]:Contains(System.Collections.Immutable.ImmutableList`1+Node[System.Numerics.Vector`1[float]],System.Numerics.Vector`1[float],System.Collections.Generic.IEqualityComparer`1[System.Numerics.Vector`1[float]]):bool (FullOpts)
          83 (56.08 % of base) : System.Collections.Immutable.dasm - System.Collections.Immutable.ImmutableList`1+Node[System.Nullable`1[int]]:Contains(System.Collections.Immutable.ImmutableList`1+Node[System.Nullable`1[int]],System.Nullable`1[int],System.Collections.Generic.IEqualityComparer`1[System.Nullable`1[int]]):bool (FullOpts)
          72 (77.42 % of base) : System.IO.Packaging.dasm - System.IO.Packaging.XmlCompatibilityReader+CompatibilityScope:CanIgnore(System.String):bool:this (FullOpts)
          62 (60.78 % of base) : System.Collections.Immutable.dasm - System.Collections.Immutable.ImmutableList`1+Node[double]:AddRange(System.ReadOnlySpan`1[double]):System.Collections.Immutable.ImmutableList`1+Node[double]:this (FullOpts)
          62 (60.78 % of base) : System.Collections.Immutable.dasm - System.Collections.Immutable.ImmutableList`1+Node[int]:AddRange(System.ReadOnlySpan`1[int]):System.Collections.Immutable.ImmutableList`1+Node[int]:this (FullOpts)
          62 (60.78 % of base) : System.Collections.Immutable.dasm - System.Collections.Immutable.ImmutableList`1+Node[long]:AddRange(System.ReadOnlySpan`1[long]):System.Collections.Immutable.ImmutableList`1+Node[long]:this (FullOpts)
          62 (60.78 % of base) : System.Collections.Immutable.dasm - System.Collections.Immutable.ImmutableList`1+Node[short]:AddRange(System.ReadOnlySpan`1[short]):System.Collections.Immutable.ImmutableList`1+Node[short]:this (FullOpts)
          62 (60.78 % of base) : System.Collections.Immutable.dasm - System.Collections.Immutable.ImmutableList`1+Node[System.Nullable`1[int]]:AddRange(System.ReadOnlySpan`1[System.Nullable`1[int]]):System.Collections.Immutable.ImmutableList`1+Node[System.Nullable`1[int]]:this (FullOpts)
          62 (60.78 % of base) : System.Collections.Immutable.dasm - System.Collections.Immutable.ImmutableList`1+Node[System.Numerics.Vector`1[float]]:AddRange(System.ReadOnlySpan`1[System.Numerics.Vector`1[float]]):System.Collections.Immutable.ImmutableList`1+Node[System.Numerics.Vector`1[float]]:this (FullOpts)
          62 (60.78 % of base) : System.Collections.Immutable.dasm - System.Collections.Immutable.ImmutableList`1+Node[ubyte]:AddRange(System.ReadOnlySpan`1[ubyte]):System.Collections.Immutable.ImmutableList`1+Node[ubyte]:this (FullOpts)
          20 (36.36 % of base) : System.Private.Xml.dasm - System.Xml.Xsl.Runtime.XmlSortKey:AddSortKey(System.Xml.Xsl.Runtime.XmlSortKey):System.Xml.Xsl.Runtime.XmlSortKey:this (FullOpts)
           7 (4.22 % of base) : System.Private.DataContractSerialization.dasm - System.Runtime.Serialization.Json.JsonWriterDelegator:WriteStartElement(System.String,System.String,System.String):this (FullOpts)

Top method improvements (bytes):
         -52 (-15.20 % of base) : Microsoft.NET.WebAssembly.Webcil.dasm - Microsoft.NET.WebAssembly.Webcil.WebcilConverter+PEFileInfo:Equals(Microsoft.NET.WebAssembly.Webcil.WebcilConverter+PEFileInfo):bool:this (FullOpts)
         -51 (-16.04 % of base) : Microsoft.NET.WebAssembly.Webcil.dasm - Microsoft.NET.WebAssembly.Webcil.WebcilConverter+PEFileInfo:GetHashCode():int:this (FullOpts)
         -49 (-14.37 % of base) : Microsoft.NET.WebAssembly.Webcil.dasm - Microsoft.NET.WebAssembly.Webcil.WebcilConverter+WCFileInfo:GetHashCode():int:this (FullOpts)
         -42 (-10.45 % of base) : Microsoft.NET.WebAssembly.Webcil.dasm - Microsoft.NET.WebAssembly.Webcil.WebcilConverter+WCFileInfo:Equals(Microsoft.NET.WebAssembly.Webcil.WebcilConverter+WCFileInfo):bool:this (FullOpts)
         -34 (-22.67 % of base) : System.Private.Xml.dasm - System.Xml.Serialization.SourceInfo:Equals(System.Object):bool:this (FullOpts)

Top method regressions (percentages):
         600 (154.24 % of base) : System.Data.Common.dasm - System.Data.RBTree`1[System.Numerics.Vector`1[float]]:IndexOf(int,System.Numerics.Vector`1[float]):int:this (FullOpts)
         298 (85.39 % of base) : System.ComponentModel.Composition.dasm - System.ComponentModel.Composition.Hosting.ImportEngine+EngineContext:GetAddedPartManagers():System.Collections.Generic.IEnumerable`1[System.ComponentModel.Composition.Hosting.ImportEngine+PartManager]:this (FullOpts)
         298 (85.39 % of base) : System.ComponentModel.Composition.dasm - System.ComponentModel.Composition.Hosting.ImportEngine+EngineContext:GetRemovedPartManagers():System.Collections.Generic.IEnumerable`1[System.ComponentModel.Composition.Hosting.ImportEngine+PartManager]:this (FullOpts)
          72 (77.42 % of base) : System.IO.Packaging.dasm - System.IO.Packaging.XmlCompatibilityReader+CompatibilityScope:CanIgnore(System.String):bool:this (FullOpts)
         213 (75.80 % of base) : System.Collections.Immutable.dasm - System.Collections.Immutable.ImmutableList`1+Node[System.Numerics.Vector`1[float]]:Add(System.Numerics.Vector`1[float]):System.Collections.Immutable.ImmutableList`1+Node[System.Numerics.Vector`1[float]]:this (FullOpts)
          62 (60.78 % of base) : System.Collections.Immutable.dasm - System.Collections.Immutable.ImmutableList`1+Node[double]:AddRange(System.ReadOnlySpan`1[double]):System.Collections.Immutable.ImmutableList`1+Node[double]:this (FullOpts)
          62 (60.78 % of base) : System.Collections.Immutable.dasm - System.Collections.Immutable.ImmutableList`1+Node[int]:AddRange(System.ReadOnlySpan`1[int]):System.Collections.Immutable.ImmutableList`1+Node[int]:this (FullOpts)
          62 (60.78 % of base) : System.Collections.Immutable.dasm - System.Collections.Immutable.ImmutableList`1+Node[long]:AddRange(System.ReadOnlySpan`1[long]):System.Collections.Immutable.ImmutableList`1+Node[long]:this (FullOpts)
          62 (60.78 % of base) : System.Collections.Immutable.dasm - System.Collections.Immutable.ImmutableList`1+Node[short]:AddRange(System.ReadOnlySpan`1[short]):System.Collections.Immutable.ImmutableList`1+Node[short]:this (FullOpts)
          62 (60.78 % of base) : System.Collections.Immutable.dasm - System.Collections.Immutable.ImmutableList`1+Node[System.Nullable`1[int]]:AddRange(System.ReadOnlySpan`1[System.Nullable`1[int]]):System.Collections.Immutable.ImmutableList`1+Node[System.Nullable`1[int]]:this (FullOpts)
          62 (60.78 % of base) : System.Collections.Immutable.dasm - System.Collections.Immutable.ImmutableList`1+Node[System.Numerics.Vector`1[float]]:AddRange(System.ReadOnlySpan`1[System.Numerics.Vector`1[float]]):System.Collections.Immutable.ImmutableList`1+Node[System.Numerics.Vector`1[float]]:this (FullOpts)
          62 (60.78 % of base) : System.Collections.Immutable.dasm - System.Collections.Immutable.ImmutableList`1+Node[ubyte]:AddRange(System.ReadOnlySpan`1[ubyte]):System.Collections.Immutable.ImmutableList`1+Node[ubyte]:this (FullOpts)
          83 (56.08 % of base) : System.Collections.Immutable.dasm - System.Collections.Immutable.ImmutableList`1+Node[System.Nullable`1[int]]:Contains(System.Collections.Immutable.ImmutableList`1+Node[System.Nullable`1[int]],System.Nullable`1[int],System.Collections.Generic.IEqualityComparer`1[System.Nullable`1[int]]):bool (FullOpts)
          99 (55.31 % of base) : System.Collections.Immutable.dasm - System.Collections.Immutable.ImmutableList`1+Node[System.Numerics.Vector`1[float]]:Contains(System.Collections.Immutable.ImmutableList`1+Node[System.Numerics.Vector`1[float]],System.Numerics.Vector`1[float],System.Collections.Generic.IEqualityComparer`1[System.Numerics.Vector`1[float]]):bool (FullOpts)
          20 (36.36 % of base) : System.Private.Xml.dasm - System.Xml.Xsl.Runtime.XmlSortKey:AddSortKey(System.Xml.Xsl.Runtime.XmlSortKey):System.Xml.Xsl.Runtime.XmlSortKey:this (FullOpts)
           7 (4.22 % of base) : System.Private.DataContractSerialization.dasm - System.Runtime.Serialization.Json.JsonWriterDelegator:WriteStartElement(System.String,System.String,System.String):this (FullOpts)

Top method improvements (percentages):
         -34 (-22.67 % of base) : System.Private.Xml.dasm - System.Xml.Serialization.SourceInfo:Equals(System.Object):bool:this (FullOpts)
         -51 (-16.04 % of base) : Microsoft.NET.WebAssembly.Webcil.dasm - Microsoft.NET.WebAssembly.Webcil.WebcilConverter+PEFileInfo:GetHashCode():int:this (FullOpts)
         -52 (-15.20 % of base) : Microsoft.NET.WebAssembly.Webcil.dasm - Microsoft.NET.WebAssembly.Webcil.WebcilConverter+PEFileInfo:Equals(Microsoft.NET.WebAssembly.Webcil.WebcilConverter+PEFileInfo):bool:this (FullOpts)
         -49 (-14.37 % of base) : Microsoft.NET.WebAssembly.Webcil.dasm - Microsoft.NET.WebAssembly.Webcil.WebcilConverter+WCFileInfo:GetHashCode():int:this (FullOpts)
         -42 (-10.45 % of base) : Microsoft.NET.WebAssembly.Webcil.dasm - Microsoft.NET.WebAssembly.Webcil.WebcilConverter+WCFileInfo:Equals(Microsoft.NET.WebAssembly.Webcil.WebcilConverter+WCFileInfo):bool:this (FullOpts)

21 total methods with Code Size differences (5 improved, 16 regressed), 232352 unchanged.

--------------------------------------------------------------------------------

Artifacts:

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions