Skip to content

Conversation

@vbryh-msft
Copy link
Contributor

No description provided.

@vbryh-msft vbryh-msft requested a review from david-risney June 6, 2022 17:08
@vbryh-msft vbryh-msft requested a review from david-risney June 17, 2022 20:01
@vbryh-msft vbryh-msft requested a review from david-risney June 27, 2022 16:35
Copy link
Contributor

@david-risney david-risney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please address remaining issues I raised and then open the PR to main and I'll schedule a review.


/// Event args for the `WebResourceRequested` event.
[uuid(572f38f9-c317-4b6c-8dd2-c8b894779bbb), object, pointer_default(unique)]
interface ICoreWebView2WebResourceRequestedEventArgs : IUnknown {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an extension of an existing interface right?

Suggested change
interface ICoreWebView2WebResourceRequestedEventArgs : IUnknown {
interface ICoreWebView2WebResourceRequestedEventArgs2 : ICoreWebView2WebResourceRequestedEventArgs {

@vbryh-msft vbryh-msft merged commit 660b372 into api-webresourcerequested-workers Jun 29, 2022
@vbryh-msft vbryh-msft deleted the api-webresourcerequested-workers-draft branch July 10, 2023 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants