Skip to content

Try to document relative icons #875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

DHowett
Copy link
Contributor

@DHowett DHowett commented Aug 5, 2025

No description provided.

Copy link

Learn Build status updates of commit 56b3ced:

✅ Validation status: passed

File Status Preview URL Details
TerminalDocs/command-palette.md ✅Succeeded View
TerminalDocs/customize-settings/actions.md ✅Succeeded View
TerminalDocs/customize-settings/appearance.md ✅Succeeded View
TerminalDocs/customize-settings/profile-appearance.md ✅Succeeded View
TerminalDocs/customize-settings/profile-general.md ✅Succeeded View
TerminalDocs/json-fragment-extensions.md ✅Succeeded View

For more details, please refer to the build report.

@DHowett
Copy link
Contributor Author

DHowett commented Aug 5, 2025

@crramirez does this seem sensible? i think I'm in too deep

image

@crramirez
Copy link

crramirez commented Aug 6, 2025

Looks very very good. Thanks a lot for this. I'll try this weekend to compile it and give it a try.

Now that you are in the context, I have a related question. How doable is to specify flags into the icon's name to choose different ones depending on the dark/light theme as XAML (resource management) does? I have two apps that I have to modify the icons via the app to match the theme, but i cannot guess the terminal menu theme. Example:

image

Can you pick the right one depending on the theme?

If you say that it is doable, I'll create a descriptive issue requesting it.

Thanks a lot again for your hard work. (I've seen the lot of commits)

@DHowett
Copy link
Contributor Author

DHowett commented Aug 6, 2025

Hmmmm... that might require some lifting, but it seems doable.

If you want to try out the latest, it came out in last night's Canary build (https://aka.ms/terminal-canary-installer)!

@crramirez
Copy link

wow I don't need to compile it? amazing. The last one and a leave you alone (for a while)

If I have an ico file with the following images ALL PNGs with the following sizes:

  • 16 × 16 px
  • 24 × 24 px
  • 32 × 32 px
  • 48 × 48 px
  • 64 × 64 px
  • 128 × 128 px
  • 256 × 256 px

Will be possible that terminal pick the right one depending on the Display scale? Currently I think it is picking the 256 size and reducing it:

image

Again, I can create a separate issue for that.

@DHowett
Copy link
Contributor Author

DHowett commented Aug 6, 2025

@crramirez 😢 this is expected to work but once again we have been let down by WinUI

This comment was marked as outdated.

Copy link

Learn Build status updates of commit a908a29:

✅ Validation status: passed

File Status Preview URL Details
TerminalDocs/command-palette.md ✅Succeeded View
TerminalDocs/customize-settings/actions.md ✅Succeeded View
TerminalDocs/customize-settings/appearance.md ✅Succeeded View
TerminalDocs/customize-settings/profile-appearance.md ✅Succeeded View
TerminalDocs/customize-settings/profile-general.md ✅Succeeded View
TerminalDocs/json-fragment-extensions.md ✅Succeeded View

For more details, please refer to the build report.

@crramirez
Copy link

Ok @DHowett I'll do the proper testing in the canary build and create an issue if I see something.

BTW, the new SSH entries rocks!!!!

@DHowett
Copy link
Contributor Author

DHowett commented Aug 6, 2025

Oh, thanks so much! @carlos-zamora will be happy to hear that. We're still trying to figure out what to do about them in general. Some folks will have lots, and we may want to put them in a folder.

FWIW, I was against having them at all. My ssh config is for my own use, not as a list of "places I want surfaced in an application". 🤷🏻

@crramirez
Copy link

Happily for you also the extension management was implemented so you just have to disable the ssh extension :-D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants