Andres Grobas - .NET Backend Task #783
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modifications in ExchangeRatesProvider: get/set to cache, read default currencies from options. CNB client from factory with configurable policies Cancellations management. Added unit testing. Added Dockerfile
Corrections in DI for httpClient. Request validation with ValidationAttribute. Changes in log levels. Null warnings. Improve cache expiration logic
Included CNB data last update in cache expiration calculation.
Use extension methods for DI.
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of a .NET 8 web API that consumes the Czech National Bank (CNB) API to retrieve daily exchange rates. The solution follows a layered architecture with separate API, Application, and Infrastructure projects. It also includes configuration options, distributed caching, HTTP client resilience policies and Swagger documentation.