Speed up test script #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test script now builds and tests without removing the `dist` directory first. This speeds up the test script a little bit (~0.5 seconds for me, usually). Removing the directory seemed a bit excessive, particularly if someone had enabled incremental builds. A new `build:clean` script has been added to remove `dist` and build, and this is used in the `prepublishOnly` script. This should ensure the build used for publishing is always complete, with no extraneous files. Also `rimraf` is now used for deleting `dist`, to improve platform compatibility for contributors.
Gudahtt
force-pushed
the
speed-up-test-script
branch
from
9b57fb3 to
cc7f24b
Compare
shanejonas
approved these changes
Jun 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test script now builds and tests without removing the
distdirectory first. This speeds up the test script a little bit (~0.5 seconds for me, usually). Removing the directory seemed a bit excessive, particularly if someone had enabled incremental builds.A new
build:cleanscript has been added to removedistand build, and this is used in theprepublishOnlyscript. This should ensure the build used for publishing is always complete, with no extraneous files.Also
rimrafis now used for deletingdist, to improve platform compatibility for contributors.