Skip to content

Conversation

@elefantel
Copy link
Contributor

@elefantel elefantel commented Aug 12, 2024

Fixes #131

  • Add unit tests for CommunicationClient - the client responsible for AIDL communication with MetaMask wallet
  • Add Mockito testing dependency for mocking application context and for stubbing behaviour of bound service connections
  • Add CommunicationClientModule - a factory class for producing the client's dependencies
  • Encapsulate the AIDL bound service to improve modularity and testability by moving it out from CommunicationClient into
    ClientServiceConnection for managing connections and sending messages
    ClientMessageServiceCallback for managing received messages

@elefantel elefantel requested a review from a team as a code owner August 12, 2024 11:57
@elefantel elefantel self-assigned this Aug 12, 2024
@BjornGunnarsson
Copy link

@andreahaku can you take a look at this

Copy link
Contributor

@andreahaku andreahaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small comment. the rest is ok.

Remove date comment
Copy link
Contributor

@andreahaku andreahaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elefantel elefantel merged commit 2d2e095 into main Aug 14, 2024
@elefantel elefantel deleted the communication-client-tests branch August 15, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Communication client unit tests

4 participants