chore: sync dapp state after async fetching cached state #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmeytee
reviewed
Jul 30, 2024
Comment on lines
49
to
+53
| // Expose plain variables for developers who prefer not using observing live data via ethereumState | ||
| val chainId: String | ||
| get() = currentEthereumState.chainId | ||
| get() = if (currentEthereumState.chainId.isEmpty()) { currentEthereumState.chainId } else { cachedChainId } | ||
| val selectedAddress: String | ||
| get() = currentEthereumState.selectedAddress | ||
| get() = if (currentEthereumState.selectedAddress.isEmpty()) { currentEthereumState.selectedAddress } else { cachedAccount } |
There was a problem hiding this comment.
Allways returns cached or empty.
Maybe:
val chainId: String
get() = currentEthereumState.chainId.ifEmpty { cachedChainId }
val selectedAddress: String
get() = currentEthereumState.selectedAddress.ifEmpty { cachedAccount }
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that the dapp updates the consumer of the sdk after it has fetched a cached session on startup