Skip to content

feat: Add an optional header prefix for the example dapp to make testing easier #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 24, 2024
Merged

feat: Add an optional header prefix for the example dapp to make testing easier #132

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
18184fd
feat: add an option labelPrefix to the example dapp for easier testing
christopherferreira9 Jul 24, 2024
8787a4d
fix: address comments
christopherferreira9 Jul 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions app/src/main/java/com/metamask/dapp/DappActionsScreen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,11 +36,19 @@ fun DappActionsScreen(
Heading("Dapp Actions")

DappLabel(
labelPrefix = "Account:",
text = ethereumState.selectedAddress,
color = Color.Unspecified,
modifier = Modifier.padding(bottom = 36.dp)
)

DappLabel(
labelPrefix = "ChainId:",
text = ethereumState.chainId,
color = Color.Unspecified,
modifier = Modifier.padding(bottom = 36.dp)
)

Spacer(modifier = Modifier.weight(1f))

// Sign message button
Expand Down
9 changes: 9 additions & 0 deletions app/src/main/java/com/metamask/dapp/DappLabel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,20 @@ import androidx.compose.ui.unit.sp

@Composable
fun DappLabel(
labelPrefix: String = "",
text: String,
color: Color = Color.White,
fontSize: TextUnit = 14.sp,
modifier: Modifier = Modifier.padding(bottom = 12.dp)
) {
if (labelPrefix.isNotEmpty()) {
Text(
text = labelPrefix,
color = color,
fontSize = fontSize.times(1.3),
modifier = Modifier.padding(bottom = 5.dp)
)
}
Text(
text = text,
color = color,
Expand Down