-
Notifications
You must be signed in to change notification settings - Fork 1
Add FY3-E MWSFY3E obtype #248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ctgh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this. I realise it's very similar to an existing case, but perhaps consider adding another Cx Writer ctest in order to ensure it is covered.
mikecooke77
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Accidentally overwrote MWSSG!
preserve alphabetical order
|
CI failing the same way as mo-bundle workflow running in my environment. |
Thanks Chris - I've added a test. Hopefully correctly. But I notice that it's failing. I haven't added anything to ioda which I notice is used here. Do I need to? |
At the very least I forgot to actually run the python script to generate the unit test python which I have now done and added. I see that ioda is a dependency but I don't have a PR to implement a test there yet. I'm in the process of adding it now. |
ctgh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the changes and adding the new test. I'll merge once the CI has completed.
Add MWSFY3E obtype which is an almost straight copy of MWSFY3 with a few more channels (but it's still store in the MWTS MetDB type)