Skip to content

Conversation

@david-rundle
Copy link
Contributor

Add MWSFY3E obtype which is an almost straight copy of MWSFY3 with a few more channels (but it's still store in the MWTS MetDB type)

Copy link
Collaborator

@ctgh ctgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this. I realise it's very similar to an existing case, but perhaps consider adding another Cx Writer ctest in order to ensure it is covered.

Copy link
Collaborator

@mikecooke77 mikecooke77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Accidentally overwrote MWSSG!
preserve alphabetical order
@matthewrmshin
Copy link
Collaborator

CI failing the same way as mo-bundle workflow running in my environment.

@david-rundle
Copy link
Contributor Author

Thanks for adding this. I realise it's very similar to an existing case, but perhaps consider adding another Cx Writer ctest in order to ensure it is covered.

Thanks Chris - I've added a test. Hopefully correctly. But I notice that it's failing.

I haven't added anything to ioda which I notice is used here. Do I need to?

@david-rundle
Copy link
Contributor Author

CI failing the same way as mo-bundle workflow running in my environment.

At the very least I forgot to actually run the python script to generate the unit test python which I have now done and added.

I see that ioda is a dependency but I don't have a PR to implement a test there yet. I'm in the process of adding it now.

Copy link
Collaborator

@ctgh ctgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes and adding the new test. I'll merge once the CI has completed.

@ctgh ctgh merged commit b522ae8 into develop Nov 4, 2025
6 checks passed
@ctgh ctgh deleted the feature/mwsfy3e branch November 4, 2025 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants