Remove asymmetric crypto alt interfaces #9271
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tom-daubney-arm
added
needs-review
ronald-cron-arm
requested changes
Jun 28, 2024
Contributor
ronald-cron-arm
left a comment
ronald-cron-arm
left a comment
There was a problem hiding this comment.
LGTM but one point.
ronald-cron-arm
previously approved these changes
Jul 3, 2024
Contributor
ronald-cron-arm
left a comment
ronald-cron-arm
left a comment
There was a problem hiding this comment.
LGTM but it needs rebasing.
davidhorstmann-arm
previously approved these changes
Jul 4, 2024
Contributor
davidhorstmann-arm
left a comment
davidhorstmann-arm
left a comment
There was a problem hiding this comment.
LGTM, I will stand by for the rebase
Signed-off-by: Thomas Daubney <[email protected]>
Signed-off-by: Thomas Daubney <[email protected]>
Signed-off-by: Thomas Daubney <[email protected]>
Also removed are all options of the form MBEDTLS_ECP_XXX_ALT as well as MBEDTLS_ECP_NO_FALLBACK. Signed-off-by: Thomas Daubney <[email protected]>
Signed-off-by: Thomas Daubney <[email protected]>
tom-daubney-arm
dismissed stale reviews from davidhorstmann-arm and ronald-cron-arm
via
3507d76
tom-daubney-arm
force-pushed
the
remove_asymmetric_crypto_alt_interface
branch
from
d961434 to
3507d76
Compare
Contributor
Author
|
@ronald-cron-arm @davidhorstmann-arm I have done the rebase. Thanks for the reviews and please take another look. |
ronald-cron-arm
removed
the
needs-reviewer
davidhorstmann-arm
approved these changes
Jul 5, 2024
Contributor
davidhorstmann-arm
left a comment
davidhorstmann-arm
left a comment
There was a problem hiding this comment.
LGTM, thanks!
davidhorstmann-arm
added
approved
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove asymmetric crypto ALT interfaces.
This PR is made up of commits split out from #9226 in order to ease review.
PR checklist
Please tick as appropriate and edit the reasons (e.g.: "backport: not needed because this is a new feature")
Notes for the submitter
Please refer to the contributing guidelines, especially the
checklist for PR contributors.
Help make review efficient: