Skip to content

Replace MBEDTLS_MD_CAN_SHA3_512 with PSA_WANT_ALG_SHA3_512 #9214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 4, 2024
Merged

Replace MBEDTLS_MD_CAN_SHA3_512 with PSA_WANT_ALG_SHA3_512 #9214

merged 2 commits into from
Jul 4, 2024

Conversation

@eleuzi01
Copy link
Contributor

@eleuzi01 eleuzi01 commented May 31, 2024 •
edited
Loading

Description

Issue #9115

PR checklist

Please tick as appropriate and edit the reasons (e.g.: "backport: not needed because this is a new feature")

  • changelog not required, internal changes
  • 3.6 backport not required, needed for 4.0
  • 2.28 backport not required, needed for 4.0
  • tests not required

Notes for the submitter

Please refer to the contributing guidelines, especially the
checklist for PR contributors.

Help make review efficient:

  • Multiple simple commits
    • please structure your PR into a series of small commits, each of which does one thing
  • Avoid force-push
    • please do not force-push to update your PR - just add new commit(s)
  • See our Guidelines for Contributors for more details about the review process.

@eleuzi01 eleuzi01 added enhancement component-crypto Crypto primitives and low-level interfaces labels May 31, 2024
@eleuzi01 eleuzi01 self-assigned this May 31, 2024
@eleuzi01 eleuzi01 added the size-xs Estimated task size: extra small (a few hours at most) label May 31, 2024
@gabor-mezei-arm gabor-mezei-arm linked an issue Jun 5, 2024 that may be closed by this pull request
Replace MBEDTLS_MD_CAN_SHA3_* with its PSA_WANT counterpartarts #9115
Closed
@gabor-mezei-arm gabor-mezei-arm added the needs-preceding-pr Requires another PR to be merged first label Jun 5, 2024
@eleuzi01 eleuzi01 added needs-ci Needs to pass CI tests priority-high High priority - will be reviewed soon labels Jun 13, 2024
@eleuzi01 eleuzi01 force-pushed the replace-mbedtls-md-can-sha3-512 branch from 11b6a71 to 777d7ab Compare June 20, 2024 15:53
@eleuzi01 eleuzi01 added needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review and removed needs-preceding-pr Requires another PR to be merged first labels Jun 20, 2024
@gabor-mezei-arm gabor-mezei-arm self-requested a review June 20, 2024 16:06
@eleuzi01 eleuzi01 added needs-ci Needs to pass CI tests and removed needs-ci Needs to pass CI tests labels Jun 24, 2024
gabor-mezei-arm
gabor-mezei-arm previously approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@gabor-mezei-arm gabor-mezei-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eleuzi01 eleuzi01 force-pushed the replace-mbedtls-md-can-sha3-512 branch from fe18731 to 630bedb Compare July 2, 2024 10:18
gabor-mezei-arm
gabor-mezei-arm previously approved these changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@gabor-mezei-arm gabor-mezei-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tom-daubney-arm tom-daubney-arm self-requested a review July 2, 2024 20:55
@tom-daubney-arm tom-daubney-arm added approved Design and code approved - may be waiting for CI or backports and removed needs-reviewer This PR needs someone to pick it up for review needs-review Every commit must be reviewed by at least two team members, labels Jul 2, 2024
tom-daubney-arm
tom-daubney-arm previously approved these changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@tom-daubney-arm tom-daubney-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@gabor-mezei-arm
Copy link
Contributor

gabor-mezei-arm commented Jul 3, 2024

The legacy macro removal PRs most probably cause a merge conflict to each other so wait for the others to be merged.

@ronald-cron-arm ronald-cron-arm added this pull request to the merge queue Jul 4, 2024
@ronald-cron-arm ronald-cron-arm removed this pull request from the merge queue due to a manual request Jul 4, 2024
@eleuzi01 eleuzi01 dismissed stale reviews from tom-daubney-arm and gabor-mezei-arm via 9567fd1 July 4, 2024 10:40
@eleuzi01 eleuzi01 force-pushed the replace-mbedtls-md-can-sha3-512 branch from 630bedb to 9567fd1 Compare July 4, 2024 10:40
gabor-mezei-arm
gabor-mezei-arm approved these changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@gabor-mezei-arm gabor-mezei-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tom-daubney-arm
tom-daubney-arm approved these changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@tom-daubney-arm tom-daubney-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ronald-cron-arm ronald-cron-arm added this pull request to the merge queue Jul 4, 2024
@davidhorstmann-arm davidhorstmann-arm mentioned this pull request Jul 4, 2024
Merged
4 tasks
Merged via the queue into Mbed-TLS:development with commit cd90695 Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@gabor-mezei-arm gabor-mezei-arm gabor-mezei-arm approved these changes

@tom-daubney-arm tom-daubney-arm tom-daubney-arm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@eleuzi01 eleuzi01

Labels

approved Design and code approved - may be waiting for CI or backports component-crypto Crypto primitives and low-level interfaces enhancement priority-high High priority - will be reviewed soon size-xs Estimated task size: extra small (a few hours at most)

Projects

No open projects
Roadmap Board for Mbed TLS
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Replace MBEDTLS_MD_CAN_SHA3_* with its PSA_WANT counterpartarts

4 participants

@eleuzi01 @gabor-mezei-arm @tom-daubney-arm @ronald-cron-arm