Condition Open CI changes based on Jenkins URL #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch updates docker's run.sh with the aforementioned parameter which disables the ASLR for zeroize test. The readme.md file has been updated accordingly
This patch updates the ubuntu-16.04 & ubuntu-18.04 Dockerfiles to use the up-to-date license license information, and removes the workaround in gen_jobs.groovy script.
This patch installs the official distribution selected packages for `abi-dumper` -> (version>=1.1-1) and `abi-compliance-checker` -> (version>=2.3-0.2)
This patch updates GnuTLS 3.7 configure command to use the distribution’s `libtasn1` -> (version>=4.13). Comments have been amended accordingly
This patch updates ubuntu18-04 Dockerfiles to compile abi-compliance-checker 2.3 from source. Both files are slightly modified to remove unessary apt-get updates when using the package manager. It also adds a note to OpenSSL comments, to serve as reminder of the optional `--with-included-libtasn1` parameter.
|
Test PR: arthur-she/mbedtls#4 |
|
Hi @yanesca , Thank you Arthur |
yanesca
added
enhancement
bensze01
requested changes
Jan 31, 2022
arthur-she
force-pushed
the
leo-mbedtls-open-ci-notify-github
branch
2 times, most recently
from
db86f5a to
5430592
Compare
gilles-peskine-arm
requested changes
Feb 4, 2022
There was a problem hiding this comment.
On code inspection, this looks correct (for the Arm CI), but slightly overcomplicated in a couple of places.
Test runs on Arm CI:
- https://jenkins-mbedtls.oss.arm.com/job/mbedtls-release-ci-testing/360/ — ok
- https://jenkins-mbedtls.oss.arm.com/job/mbed-tls-pr-ci-testing/view/change-requests/job/PR-758-head/ — in progress
- https://jenkins-mbedtls.oss.arm.com/job/mbed-tls-pr-ci-testing/view/change-requests/job/PR-758-merge/ — in progress
I haven't reviewed the suitability for Open CI.
bensze01
requested changes
Feb 4, 2022
arthur-she
force-pushed
the
leo-mbedtls-open-ci-notify-github
branch
5 times, most recently
from
8d7dd05 to
19206df
Compare
This patch updates the ubuntu-16.04 & ubuntu-18.04 Dockerfiles to use the up-to-date license license information, and removes the workaround in gen_jobs.groovy script.
This patch installs the official distribution selected packages for `abi-dumper` -> (version>=1.1-1) and `abi-compliance-checker` -> (version>=2.3-0.2)
This patch updates GnuTLS 3.7 configure command to use the distribution’s `libtasn1` -> (version>=4.13). Comments have been amended accordingly
This patch updates ubuntu18-04 Dockerfiles to compile abi-compliance-checker 2.3 from source. Both files are slightly modified to remove unessary apt-get updates when using the package manager. It also adds a note to OpenSSL comments, to serve as reminder of the optional `--with-included-libtasn1` parameter.
Signed-off-by: Leonardo Sandoval <[email protected]>
TF OpenCI: job runs on the OpenCI Internal CI: job runs on the ARM internal CI Signed-off-by: Arthur She <[email protected]>
Let ARMLMD_LICENSE_FILE could be overwritten on the build time Signed-off-by: Arthur She <[email protected]>
two CI systems Signed-off-by: Arthur She <[email protected]> (cherry picked from commit 355bca2)
arthur-she
force-pushed
the
leo-mbedtls-open-ci-notify-github
branch
from
a866213 to
2978eb9
Compare
Update and cleanup docker files
|
We've merged #31. Sorry it took us a bit longer than anticipated. There are conflicts in the Docker files now, so please rebase this pull request. |
Signed-off-by: Leonardo Sandoval <[email protected]>
TF OpenCI: job runs on the OpenCI Internal CI: job runs on the ARM internal CI Signed-off-by: Arthur She <[email protected]>
Let ARMLMD_LICENSE_FILE could be overwritten on the build time Signed-off-by: Arthur She <[email protected]>
two CI systems Signed-off-by: Arthur She <[email protected]> (cherry picked from commit 355bca2)
…-she/mbedtls-test into leo-mbedtls-open-ci-notify-github
|
Hi @gilles-peskine-arm , |
|
I'm afraid the rebase doesn't look right. You're re-applying some of Minos's changes that were later overridden. Can you please rebase your own changes on top of e1a6125? The commit list shouldn't have Minos's commits anymore. |
|
Sorry about that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify the build script to fit two CIs, Trustedfirmware OpenCI and ARM internal CI.