Skip to content

Hotfix/update volume indicator versions #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 12, 2024
Merged

Hotfix/update volume indicator versions #256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
41d7b1e
Use updated version of volume built-in indicators
Mathieu2301 Sep 12, 2024
4ad99eb
Bump to 3.4.6
Mathieu2301 Sep 12, 2024
29409bf
Add a built-in indicator
Mathieu2301 Sep 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions examples/BuiltInIndicator.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,15 @@ const TradingView = require('../main');
* This example tests built-in indicators like volume-based indicators
*/

const volumeProfile = new TradingView.BuiltInIndicator('VbPFixed@tv-basicstudies-139!');
const volumeProfile = new TradingView.BuiltInIndicator('VbPFixed@tv-basicstudies-241!');

if (!process.argv[2] && !['VbPFixed@tv-basicstudies-139!', 'Volume@tv-basicstudies-144'].includes(volumeProfile.type)) {
const AUTHENTICATED_INDICATORS = [
'VbPFixed@tv-basicstudies-241',
'VbPFixed@tv-basicstudies-241!',
'Volume@tv-basicstudies-241',
];

if (!process.argv[2] && !AUTHENTICATED_INDICATORS.includes(volumeProfile.type)) {
throw Error('Please specify your \'sessionid\' cookie');
}

Expand Down
2 changes: 1 addition & 1 deletion examples/ReplayMode.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,6 @@ async function addIndicator(name, pineId, options = {}) {
});
}

addIndicator('Volume', 'Volume@tv-basicstudies-144');
addIndicator('Volume', 'Volume@tv-basicstudies-241');
addIndicator('EMA_50', 'STD;EMA', { Length: 50 });
addIndicator('EMA_200', 'STD;EMA', { Length: 200 });
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@mathieuc/tradingview",
"version": "3.4.5",
"version": "3.4.6",
"description": "Tradingview instant stocks API, indicator alerts, trading bot, and more !",
"main": "main.js",
"scripts": {
Expand Down
20 changes: 16 additions & 4 deletions src/classes/BuiltInIndicator.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
/**
* @typedef {'Volume@tv-basicstudies-144'
* | 'VbPFixed@tv-basicstudies-139!'
* @typedef {'Volume@tv-basicstudies-241'
* | 'VbPFixed@tv-basicstudies-241'
* | 'VbPFixed@tv-basicstudies-241!'
* | 'VbPFixed@tv-volumebyprice-53!'
* | 'VbPSessions@tv-volumebyprice-53'
* | 'VbPSessionsRough@tv-volumebyprice-53!'
Expand All @@ -17,11 +18,22 @@
*/

const defaultValues = {
'Volume@tv-basicstudies-144': {
'Volume@tv-basicstudies-241': {
length: 20,
col_prev_close: false,
},
'VbPFixed@tv-basicstudies-139!': {
'VbPFixed@tv-basicstudies-241': {
rowsLayout: 'Number Of Rows',
rows: 24,
volume: 'Up/Down',
vaVolume: 70,
subscribeRealtime: false,
first_bar_time: NaN,
last_bar_time: Date.now(),
extendToRight: false,
mapRightBoundaryToBarStartTime: true,
},
'VbPFixed@tv-basicstudies-241!': {
rowsLayout: 'Number Of Rows',
rows: 24,
volume: 'Up/Down',
Expand Down
2 changes: 1 addition & 1 deletion tests/builtInIndicator.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ describe('BuiltInIndicator', () => {
});

it('gets volume profile', async () => {
const volumeProfile = new TradingView.BuiltInIndicator('VbPFixed@tv-basicstudies-139!');
const volumeProfile = new TradingView.BuiltInIndicator('VbPFixed@tv-basicstudies-241!');
volumeProfile.setOption('first_bar_time', Date.now() - 10 ** 8);

const VOL = new chart.Study(volumeProfile);
Expand Down