Skip to content

Conversation

@FNeo31
Copy link

@FNeo31 FNeo31 commented Mar 24, 2020

Description

Add Drilling Cycles as made on [#16103]

Add 5 axis CNC Motion (non modal and without RTCP) [#15480]

Can see all detailed info on request above.

FNeo31 added 4 commits March 24, 2020 21:34
Add Drilling Cycles and 5 axis for CNC Mode (non modal and without RTCP)

* G81  - Drilling Cycles - drilling (Requires DRILLING_CANNED_CYCLES)
 * G82  - Drilling Cycles - spot drill (Requires DRILLING_CANNED_CYCLES)
 * G83  - Drilling Cycles - pecking (Requires DRILLING_CANNED_CYCLES)
* M168 - Set 5 axis motion on CNC. (Requires MIXING_EXTRUDER and CNC_5X)
from:
prepare_move_to_destination();
to:
prepare_internal_move_to_destination();

For SKR Pro CNC change on fastio.h
From:
#define PWM_PIN(P)        digitalPinHasPWM(P)
to:
#define PWM_PIN(P)              true //digitalPinHasPWM(P)
5 axis working without RTCP and non Modal
drilling cycles working and tested
Endstops  get triggered on M119 but didn't stop the motors
@thinkyhead thinkyhead changed the title Add Drilling Cycles and 5 axis Motion (non modal and without RTCP) Drilling Cycles, 5-Axis (non-modal & w/out RTCP) May 16, 2020
@DerAndere1 DerAndere1 mentioned this pull request Sep 20, 2020
4 tasks
@thinkyhead thinkyhead force-pushed the bugfix-2.0.x branch 3 times, most recently from 4274255 to a97a1ae Compare November 14, 2020 02:07
@sjasonsmith sjasonsmith linked an issue Nov 17, 2020 that may be closed by this pull request
@thinkyhead thinkyhead force-pushed the bugfix-2.0.x branch 2 times, most recently from 83cc0bc to 73f6426 Compare April 16, 2021 10:14
@thinkyhead
Copy link
Member

This has been merged with the latest code and cleaned up. Please test and look for any discrepancies.

Note that this is similar to #14225 and also related to #19112. We will need to combine all of these together, but #19112 seems like it would be the best one to get completed first. It adds 3 more axes in a more generic way, so features that need extra axes such as 5-axis and Hangprinter can use it as their foundation.

@FNeo31
Copy link
Author

FNeo31 commented May 14, 2021

I agree with you @thinkyhead , at first put the @DerAndere1 branch working well and added to main Marlin so after I can rework the 5 axis moves on them. It's easier for me make this. Now I have a machine to test it in CNC mode with a SKR Pro board and with a closed loop drivers but I can test the TMC2209/2208/2225 and the normal A4988 drivers I have the machine with dual Z, probe, and the 5axis bed

What could be added directly on main Marlin is the drilling cycles that are independent of all features (at the moment just work in 3 axis or table-table 5 axis) I didn't tested yet in G18 and G19.

FNeo31 and others added 9 commits May 16, 2021 16:58
5 axis working without RTCP and non Modal
drilling cycles working and tested
Endstops  get triggered on M119 but didn't stop the motors
Add Drilling Cycles and 5 axis for CNC Mode (non modal and without RTCP)

* G81  - Drilling Cycles - drilling (Requires DRILLING_CANNED_CYCLES)
 * G82  - Drilling Cycles - spot drill (Requires DRILLING_CANNED_CYCLES)
 * G83  - Drilling Cycles - pecking (Requires DRILLING_CANNED_CYCLES)
* M168 - Set 5 axis motion on CNC. (Requires MIXING_EXTRUDER and CNC_5X)
from:
prepare_move_to_destination();
to:
prepare_internal_move_to_destination();

For SKR Pro CNC change on fastio.h
From:
to:
clean to add 5x
@thinkyhead thinkyhead force-pushed the bugfix-2.0.x branch 3 times, most recently from 1eaff6a to aee971b Compare May 22, 2021 22:47
@thinkyhead thinkyhead force-pushed the bugfix-2.0.x branch 2 times, most recently from 9852ef9 to 0e40d47 Compare June 6, 2021 08:58
@FNeo31 FNeo31 closed this Jun 10, 2021
@FNeo31 FNeo31 deleted the branch MarlinFirmware:bugfix-2.0.x June 10, 2021 10:33
@FNeo31 FNeo31 deleted the bugfix-2.0.x branch June 10, 2021 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FR] Move 2 extruders independently

2 participants