-
-
Notifications
You must be signed in to change notification settings - Fork 19.6k
Drilling Cycles, 5-Axis (non-modal & w/out RTCP) #17283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add Drilling Cycles and 5 axis for CNC Mode (non modal and without RTCP) * G81 - Drilling Cycles - drilling (Requires DRILLING_CANNED_CYCLES) * G82 - Drilling Cycles - spot drill (Requires DRILLING_CANNED_CYCLES) * G83 - Drilling Cycles - pecking (Requires DRILLING_CANNED_CYCLES) * M168 - Set 5 axis motion on CNC. (Requires MIXING_EXTRUDER and CNC_5X)
from: prepare_move_to_destination(); to: prepare_internal_move_to_destination(); For SKR Pro CNC change on fastio.h From: #define PWM_PIN(P) digitalPinHasPWM(P) to: #define PWM_PIN(P) true //digitalPinHasPWM(P)
5 axis working without RTCP and non Modal drilling cycles working and tested Endstops get triggered on M119 but didn't stop the motors
39fe6ef to
7aed32d
Compare
7b92348 to
37176ed
Compare
4274255 to
a97a1ae
Compare
83cc0bc to
73f6426
Compare
|
This has been merged with the latest code and cleaned up. Please test and look for any discrepancies. Note that this is similar to #14225 and also related to #19112. We will need to combine all of these together, but #19112 seems like it would be the best one to get completed first. It adds 3 more axes in a more generic way, so features that need extra axes such as 5-axis and Hangprinter can use it as their foundation. |
|
I agree with you @thinkyhead , at first put the @DerAndere1 branch working well and added to main Marlin so after I can rework the 5 axis moves on them. It's easier for me make this. Now I have a machine to test it in CNC mode with a SKR Pro board and with a closed loop drivers but I can test the TMC2209/2208/2225 and the normal A4988 drivers I have the machine with dual Z, probe, and the 5axis bed What could be added directly on main Marlin is the drilling cycles that are independent of all features (at the moment just work in 3 axis or table-table 5 axis) I didn't tested yet in G18 and G19. |
5 axis working without RTCP and non Modal drilling cycles working and tested Endstops get triggered on M119 but didn't stop the motors
Add Drilling Cycles and 5 axis for CNC Mode (non modal and without RTCP) * G81 - Drilling Cycles - drilling (Requires DRILLING_CANNED_CYCLES) * G82 - Drilling Cycles - spot drill (Requires DRILLING_CANNED_CYCLES) * G83 - Drilling Cycles - pecking (Requires DRILLING_CANNED_CYCLES) * M168 - Set 5 axis motion on CNC. (Requires MIXING_EXTRUDER and CNC_5X)
from: prepare_move_to_destination(); to: prepare_internal_move_to_destination(); For SKR Pro CNC change on fastio.h From: to:
clean to add 5x
1eaff6a to
aee971b
Compare
9852ef9 to
0e40d47
Compare
Description
Add Drilling Cycles as made on [#16103]
Add 5 axis CNC Motion (non modal and without RTCP) [#15480]
Can see all detailed info on request above.