Skip to content

Conversation

@jamos-tay
Copy link
Contributor

What is the purpose of this pull request? (put "X" next to an item, remove the rest)

• [X] Documentation update

What is the rationale for this request?

Somehow during the documentation restructuring the filterTags documentation was changed to the older, incorrect one (#474). It should be the one from #689.

What changes did you make? (Give an overview)

Replaced it with the newer one (#689)

Copy link
Member

@yamgent yamgent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • siteConfiguration.md still shows the wrong way of using "tags" settings.
  • This part of the code may not be very clear that it is inside "filterTags"?

```json
site.json
{
...
"tags": ["-language--*", "language--C#"]
}
```
`language--java` is overridden by `-language--*`, so only `language--C#` is shown.

@jamos-tay
Copy link
Contributor Author

Updated

Copy link
Member

@yamgent yamgent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the late review

@jamos-tay
Copy link
Contributor Author

Updated, rebased

@yamgent yamgent added this to the v1.21.1 milestone Mar 23, 2019
@yamgent yamgent merged commit a58a410 into MarkBind:master Mar 24, 2019
@yamgent yamgent changed the title Fix tagging documentation under plugins docs: Update outdated plugin documentation Mar 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants