Revert "MDBF-1136: add vcpkg setup and HashiCorp Vault tests Windows MSI builds #868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…MSI builds" This reverts commit 670c087. Building the HashiCorp Management plugin will cause the client and the server to be dynamically linked to `zlib1.dll`. See: https://jira.mariadb.org/browse/MDBF-1136?page=com.atlassian.jira.plugin.system.issuetabpanels%3Aall-tabpanel#:~:text=This%20is%20dependency,vcpkg%27s%20zlib1.dll One solution to the problem is to configure the server with `-DWITH_ZLIB=bundled` but it needs a fix in HashiCorp CMakeLists.txt to work around a `vcpkg` find_package overwrite. See: https://jira.mariadb.org/browse/MDBF-1136?page=com.atlassian.jira.plugin.system.issuetabpanels%3Aall-tabpanel#:~:text=This%20would%20fix,disables%20that%20check. I will re-apply this patch, with `-DWITH_ZLIB=bundled` added when the server changes are merged in all branches.
grooverdan
approved these changes
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 670c087.
Building the HashiCorp Management plugin will cause the client and the server to be dynamically linked to
zlib1.dll. See: https://jira.mariadb.org/browse/MDBF-1136?page=com.atlassian.jira.plugin.system.issuetabpanels%3Aall-tabpanel#:~:text=This%20is%20dependency,vcpkg%27s%20zlib1.dllOne solution to the problem is to configure the server with
-DWITH_ZLIB=bundledbut it needs a fix in HashiCorp CMakeLists.txt to work around avcpkgfind_package overwrite. See: https://jira.mariadb.org/browse/MDBF-1136?page=com.atlassian.jira.plugin.system.issuetabpanels%3Aall-tabpanel#:~:text=This%20would%20fix,disables%20that%20check.I will re-apply this patch, with
-DWITH_ZLIB=bundledadded when the server changes are merged in all branches.