other migration master improvements, but unneeded for infer #866
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add optional targets to the CompileCMakeCommand
Non-impacting change; now depth is optional, and depth 0 means there is no depth limit.
The builddir doesn't need to be the current dir. This adds builddir as an option with its default value of None meaning that the previous default behaviour is observed. builddir as chosen for consistency with the CompileCMake command and it looks a little out of place beside source_path in consistency of naming. Also source_path uses a CMake -S argument rather than just defaulting to this source_path value for additional clarity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was going to use this, then just scripted it all :-)