Skip to content

Conversation

@grooverdan
Copy link
Member

Add New Build template

Checklist

  • [N/A] Make changes os_info.yaml
  • [*] Schedule the builder for the appropriate branch in constants.py
  • [*] Add builder configuration

@grooverdan grooverdan force-pushed the more_galera branch 2 times, most recently from b4c1075 to 91f4e3c Compare July 9, 2024 02:11
@grooverdan
Copy link
Member Author

help. I can't work out what the worker is meant to be.

c["builders"].append(
util.BuilderConfig(
name="amd64-ubuntu-2404-debug",
workernames=workers["x64-bbw-ubuntu-2404-debug"],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be workers['x64-bbw-docker-ubuntu-2404-debug']
And the list contains the following actual workers:

image

constants.py Outdated
"aarch64-debian-12",
"amd64-fedora-39",
"amd64-fedora-40",
"amd64-ubuntu-2004-debug",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2004 it's a typo or do we want to add Galera tests to a Protected branches builder?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo. Thanks. Protected branch builders should be a bit more planned.

@grooverdan
Copy link
Member Author

s390x load implications

@grooverdan grooverdan changed the title More Galera tests + 2404-debug test MDBF-811 More Galera tests + 2404-debug test Oct 22, 2024
@RazvanLiviuVarzaru
Copy link
Collaborator

@grooverdan Spotted a bug in the codebase, if you can just update the PR please.
In utils.py

it should be builderName == b
otherwise builder_name is in builder_name_debug so we end up testing Galera on wrong builders.

def hasGalera(props):
    builderName = str(props.getProperty("buildername"))

    for b in builders_galera_mtr:
        if builderName in b:
            return True
    return False

It was odd seeing mostly ppc64le/s390x test failures.
This was because these where the main tests of galera.

As there is no debug build of galera, added amd64-2404-debug
as a builder so that there is coverage of galera in a debug
build which has additional tests.
With MariaDB Operator doing UBI based container
operability with galera, more RHEL based galera
tests needed to catch operability problems ealier.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants