Skip to content

Conversation

@Munksgaard
Copy link
Collaborator

Fixes #135

@Munksgaard Munksgaard force-pushed the rustc-optin branch 2 times, most recently from 3be6360 to d32908d Compare November 13, 2019 11:14
@Munksgaard
Copy link
Collaborator Author

This may break some users, so I suggest we bump either the minor or major version before releasing.

@laumann
Copy link
Collaborator

laumann commented Nov 14, 2019

At the very least, it should be a minor version (in a separate commit).

If it's only a minor release, I think you should also leave in the stable feature flag (but have it do nothing), so as not to break users of that flag. I'm not sure what to do with users that do not use stable.

It doesn't do anything and should be removed at next major release
@Munksgaard
Copy link
Collaborator Author

If it's only a minor release, I think you should also leave in the stable feature flag (but have it do nothing), so as not to break users of that flag. I'm not sure what to do with users that do not use stable.

Good point, I've gone ahead and done that.

@Munksgaard Munksgaard merged commit 326f119 into master Nov 16, 2019
Munksgaard added a commit that referenced this pull request Nov 18, 2019
This should've been part of #200

Fixes #205
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make "stable" the default, require Cargo feature to opt in to pretty-printer support

4 participants