Make it easier to change background color #716
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I don't mind if we pursue a different approach for making it easier to change background color, but it took me a while to figure out how a corresponding (non-graphical) test could look like -- and mainly because I liked the outcome of this process, I opened this PR. |
leotrs
approved these changes
Nov 16, 2020
Contributor
leotrs
left a comment
leotrs
left a comment
There was a problem hiding this comment.
A bit messy, but I think this is the best we can do for now.
huguesdevimeux
requested changes
Nov 16, 2020
leotrs
approved these changes
Nov 16, 2020
huguesdevimeux
approved these changes
Nov 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of Changes
background_colorandbackground_opacityto become properties ofCameracameraproperty toSceneMotivation
This is a suggestion for simplifying the interface for setting the background color in a scene by calling
self.camera.background_color = REDetc, which was briefly discussed in #604.Resolves #604.
Acknowledgement