Skip to content

Update docker to use ENV x=y instead of ENV x y #3858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 14, 2024
Merged

Update docker to use ENV x=y instead of ENV x y #3858

merged 1 commit into from
Jul 14, 2024

Conversation

@JasonGrace2282
Copy link
Member

@JasonGrace2282 JasonGrace2282 commented Jul 14, 2024

@JasonGrace2282 JasonGrace2282 added the maintenance refactoring, typos, removing clutter/dead code, and other code quality improvements label Jul 14, 2024
@JasonGrace2282 JasonGrace2282 added this to the v0.19.0 milestone Jul 14, 2024
@JasonGrace2282 JasonGrace2282 self-assigned this Jul 14, 2024
behackl
behackl approved these changes Jul 14, 2024
View reviewed changes
Copy link
Member

@behackl behackl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@behackl behackl merged commit 205f746 into ManimCommunity:main Jul 14, 2024
@JasonGrace2282 JasonGrace2282 deleted the docker-env branch July 14, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@behackl behackl behackl approved these changes

Assignees

@JasonGrace2282 JasonGrace2282

Labels

maintenance refactoring, typos, removing clutter/dead code, and other code quality improvements

Projects

Dev Board
Status: ✅ Done

Milestone

v0.19.0

Development

Successfully merging this pull request may close these issues.

2 participants

@JasonGrace2282 @behackl