-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Fix animations with zero runtime length to give a useful error instead of a broken pipe #3491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
a980b90
Fix animation group not erroring when instantiated with an empty list
MrDiver 3d8f269
Move error messages into Animation.begin()
MrDiver 3c5bd82
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 5fd208c
Added tests
MrDiver de8a55d
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] fdc0ccd
Update manim/animation/animation.py
MrDiver cfdc8c5
Update manim/animation/composition.py
MrDiver d932b57
Merge branch 'main' into animation_group_empty
MrDiver d4621e4
Update manim/animation/animation.py
MrDiver 003952b
Merge branch 'main' into animation_group_empty
MrDiver File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.