-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Adding the ability to pass lists and generators to .play() #3365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 7 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
cd4befb
adding the ability to pass lists and generators to .play()
MrDiver d2ff557
fix for _AnimationBuilder
MrDiver 77b259b
Merge branch 'main' into list-gen-play
MrDiver cf797ae
Merge branch 'main' into list-gen-play
JasonGrace2282 d7c4290
Changed handling of generators to accept lists of generators and norm…
MrDiver b46d60c
Animation group handles generators
MrDiver 06b138d
Refactored into own function for reusability
MrDiver 422a66b
Fix typing
MrDiver 6ea39f9
Fix typing
MrDiver a3a331f
Merge branch 'main' into list-gen-play
JasonGrace2282 e74d566
Merge branch 'main' into list-gen-play
JasonGrace2282 442d15e
Merge branch 'main' into list-gen-play
MrDiver File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| from types import GeneratorType | ||
| from typing import Iterable, TypeVar | ||
|
|
||
| T = TypeVar("T") | ||
|
|
||
|
|
||
| def flatten_iterable_parameters( | ||
| args: Iterable[T | Iterable[T] | GeneratorType], | ||
| ) -> list[T]: | ||
| """Flattens an iterable of parameters into a list of parameters. | ||
|
|
||
| Parameters | ||
| ---------- | ||
| args | ||
| The iterable of parameters to flatten. | ||
| [(generator), [], (), ...] | ||
|
|
||
| Returns | ||
| ------- | ||
| :class:`list` | ||
| The flattened list of parameters. | ||
| """ | ||
| flattened_parameters = [] | ||
| for arg in args: | ||
| if isinstance(arg, (Iterable, GeneratorType)): | ||
| flattened_parameters.extend(arg) | ||
| else: | ||
| flattened_parameters.append(arg) | ||
| return flattened_parameters |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.