Add PxeServer.verify_depot_settings_queue #21013
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chessbyte
reviewed
Feb 4, 2021
Fryguy
reviewed
Feb 4, 2021
Fryguy
reviewed
Feb 4, 2021
lfu
force-pushed
the
pxe_verify_credentials_926
branch
2 times, most recently
from
2ac0f36 to
b60096d
Compare
Fryguy
reviewed
Feb 5, 2021
|
|
||
| def verify_depot_settings_queue(userid, options) | ||
| task_opts = { | ||
| :action => "Verify #{display_name} Credentials", |
Member
There was a problem hiding this comment.
I don't think this is i18n compliant. @mzazrivec can you remind me of the right way to do this?
Member
There was a problem hiding this comment.
I think it's
Suggested change
| :action => "Verify #{display_name} Credentials", | |
| :action => _("Verify %{display_name} Credentials") % {:display_name => display_name} |
Member
Author
There was a problem hiding this comment.
This action would be logged into the log file and saved into task's message column. Do we really need to make it I18N compliant? @Fryguy
Contributor
There was a problem hiding this comment.
If the message ends up in a log file, then no, we're not translating that.
Member
|
@bdunne Can you please also review? |
lfu
force-pushed
the
pxe_verify_credentials_926
branch
from
b60096d to
edcc516
Compare
lfu
force-pushed
the
pxe_verify_credentials_926
branch
from
edcc516 to
d892d49
Compare
Member
|
Checked commit lfu@d892d49 with ruby 2.6.3, rubocop 0.82.0, haml-lint 0.35.0, and yamllint |
agrare
approved these changes
Mar 29, 2021
Member
|
@bdunne can you take another look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocks ManageIQ/manageiq-api#1017
ManageIQ/manageiq-api#926
@miq-bot add_label enhancement, kasparov/no