Skip to content

udp errors should result in protocol.error_received, inconsistent with vanilla asyncio #601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 26, 2024
+5 −6
Merged

udp errors should result in protocol.error_received, inconsistent with vanilla asyncio #601

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
29bba19
udp errors should result in protocol.error_received
Mar 13, 2024
dd53a3e
fixes per @fantix
Aug 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions uvloop/handles/udp.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,16 +244,15 @@ cdef class UDPTransport(UVBaseTransport):
ctx.close()

exc = convert_error(err)
self._fatal_error(exc, True)
if isinstance(exc, OSError):
run_in_context1(self.context.copy(), self._protocol.error_received, exc)
else:
self._fatal_error(exc, True)
else:
self._maybe_pause_protocol()

else:
if err < 0:
exc = convert_error(err)
self._fatal_error(exc, True)
else:
self._on_sent(None, self.context.copy())
self._on_sent(convert_error(err) if err < 0 else None, self.context.copy())

cdef _on_receive(self, bytes data, object exc, object addr):
if exc is None:
Expand Down
Loading