fix(TimeseriesOutputOption): Allow comments after simulation options without TimeseriesOutputOption #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrperezi
commented
Oct 27, 2022
rodrperezi
commented
- MODPATH config files written by ModelMuse include a comment (# some comment) after simulation options (line 3, input files).
- Current version of MODPATH (github) throws an error when reading said comment if TimeseriesOutputOption is not specified.
- TimeseriesOutputOption is a new input parameter not included still in newer versions of ModelMuse and eventually other writers.
…without TimeseriesOutputOption - MODPATH config files written by ModelMuse include a comment (# some comment) after simulation options. - Current version of MODPATH throws an error when reading said comment if TimeseriesOutputOption is not specified - TimeseriesOutputOption is a new input parameter not included still in newer versions of ModelMuse and eventually other writers
|
@rodrperezi I am discussing with Richard Winston, the developer of ModelMuse, to determine the best way to address this in the short term and the long run. |
|
Thanks @aprovost-usgs, the proposed (temporary?) fix make use of the 'E' added at the end of the line by URWORD in case of error, while using a negative number for the output unit (IOUT.LT.0). The error is triggered by URWORD trying to transform the comment ('#') to the integer of TimeseriesOutputOption. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.