[pull] master from facebook:master #772
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Changelog: [internal] Extend LeakChecker so it is available on Android (or any other platform as it is completely in C++ now). Reviewed By: JoshuaGross Differential Revision: D28600243 fbshipit-source-id: c77a003e3ffc6171e61c998508c9f34f10bb65ca
Summary: Could fix some infrequent crashes in non-Fabric. Changelog: [Internal] Reviewed By: ShikaSD Differential Revision: D28605773 fbshipit-source-id: 57555e013657e61cfb02b25d9fd14c9c15774e0e
Summary: Changelog: [Internal] Differential Revision: D28479823 fbshipit-source-id: 997c6ac137d85d22ee5052d69dae006a1a0a7aac
Summary:
Accessibility service does not announce "selected" on accessibilityState = {selected: true} of the Button Component.
Issue link - #30956
## Changelog
<!-- Help reviewers and the release process by writing your own changelog entry. For an example, see:
https://github.com/facebook/react-native/wiki/Changelog
-->
[General] [Added] - Add accessibilityState prop to Slider component
Pull Request resolved: #31145
Test Plan:
Verified accessibility states are read by voiceover and talkback. Some state values aren't handled by iOS and have been identified.
Added snapshot tests to test accessibilityState.disabled = disabled values
`js1 test Slider-test`
Reviewed By: yungsters
Differential Revision: D28337723
Pulled By: lunaleaps
fbshipit-source-id: 72a54d8d9dcf1fafb9785c81da99f32a21f3df00
Summary: This migrates all ObjC NativeModule setBridge: calls to the bridge compatible initialize: call. I filtered out ViewManagers. Changelog: [Internal] Reviewed By: fkgozali Differential Revision: D28595520 fbshipit-source-id: b0e5dd681fb3563894f1aa3da1728f0c694f04bb
Summary: Changelog: [Internal] Reviewed By: fkgozali Differential Revision: D28595955 fbshipit-source-id: e61c2d321826eafb60fdac820b76d0f7d100796a
Summary: Changelog: [Internal] Reviewed By: fkgozali Differential Revision: D28595948 fbshipit-source-id: a12207f8e0c11e1e105225404450ff335242aba7
Summary: EventDispatcherImpl uses synchronized blocks all over to make it thread-safe. I'm concerned about the perf implications of this and creating contention between JS and UI threads. This is locked behind a feature flag. Enabled only for Fabric in StaticViewConfig mode, and a feature flag, for now. Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D28591331 fbshipit-source-id: ea8f93a2e1343ce37fa78690dcb62fe03594120f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )